Fix 2.1 build issues #4443
Fix 2.1 build issues #4443
Conversation
jkotalik
commented
Dec 5, 2018
jkotalik
commented
- Removes all PackageLineup code (dead due to mondo repo)
- Use full msbuild on Windows
- Fix invalid reference to internal.aspnetcore.sdk in 2.1.x (@muratg this will require a rebuild)
- Fix shared folder references for PackageArchive task.
…core.sdk, fix shared folder references
|
Build passes 🎉. |
| "Microsoft.VisualStudio.Component.VC.Tools.x86.x64", | ||
| "Microsoft.VisualStudio.Component.VC.ATL", | ||
| "Microsoft.VisualStudio.Component.Windows10SDK.15063.Desktop" | ||
| ] |
There was a problem hiding this comment.
@jkotalik @natemcmaster How necessary is this requirement on Windows? I don't have any of these workloads installed, and I don't want to install them. Even .\build.cmd /t:restore is broken since KoreBuild complains I don't have a compatible version of MSBuild.
Can't we just skip building IISIntegration and any other projects that need these special VS workloads on Windows machines that don't have these workloads installed? We have to do this for non-Windows platforms anyway, right?
There was a problem hiding this comment.
Can't we just skip building IISIntegration and any other projects that need these special VS workloads on Windows machines that don't have these workloads installed?
We discussed this in build triage, and consensus was that we'd rather have build.cmd fail fast than fail later with mysterious errors. We'll work on improving error messages to make it more obvious how to install VS with the required workloads. Tracking issue: https://github.com/aspnet/AspNetCore-Internal/issues/1505
…e#4443) - Stop producing the 'Universe' lineup package - Removes all PackageLineup code - Use full msbuild on Windows - Fix invalid reference to internal.aspnetcore.sdk in 2.1.x - Fix shared folder references for PackageArchive task. Commit migrated from dotnet/aspnetcore@0588b13f5b1b
