Support checking for required members in minimal APIs #45084
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
captainsafia
requested review from
a team,
halter73,
brunolins16,
Tratcher and
BrennanConroy
as code owners
davidfowl
reviewed
Nov 15, 2022
| NullabilityState.Nullable => true, | ||
| // In an oblivious context, the required modifier makes | ||
| // members non-optional | ||
| NullabilityState.Unknown => !GetCustomAttributes(true).OfType<RequiredMemberAttribute>().Any(), |
There was a problem hiding this comment.
How often does this get called?
There was a problem hiding this comment.
Is NullabilityState.Unknown the same as having Disabled for nullable references?
There was a problem hiding this comment.
Is NullabilityState.Unknown the same as having Disabled for nullable references?
Yep, this represents an oblivious nullability context AKA <Nullable>disable</Nullable>.
How often does this get called?
Under an oblivious nullability context, it'll be called for every property in the AsParameters call. We can probably cache this value on PropertyAsParameterInfo as needed.
brunolins16
approved these changes
Dec 14, 2022
5 tasks
ghost
added this to the
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Part of #40099.
requiredon a reference type in an oblivious nullability context makes it non-optional.requiredon a nullable type means it is non-optional.requirednecessitates the initialization of values which we already do in RDF, nullability allows them to be initialized to null.