[release/7.0] Do not generate Content for request parameters in OpenAPI #45439
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![github-actions[bot]](https://avatars.githubusercontent.com/in/15368?s=60&v=4){kind=small}
github-actions
bot
requested review from
captainsafia and
a team
as code owners
ghost
added
the
5 tasks
mitchdenny
approved these changes
Dec 4, 2022
captainsafia
added
the
Servicing-consider
|
Hi @github-actions[bot]. Please make sure you've updated the PR description to use the Shiproom Template. Also, make sure this PR is not marked as a draft and is ready-to-merge. To learn more about how to prepare a servicing PR click here. |
|
Approved via email. |
captainsafia
added
Servicing-approved
|
Hi @github-actions[bot]. This PR was just approved to be included in the upcoming servicing release. Somebody from the @dotnet/aspnet-build team will get it merged when the branches are open. Until then, please make sure all the CI checks pass and the PR is reviewed. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Backport of #45404 to release/7.0
/cc @captainsafia
Do not generate Content for request parameters in OpenAPI
This PR addresses a bug where the OpenAPI generator produced incorrect definitions for parameters defined in headers/routes/queries/etc.
Fixes #45365
Customer Impact
Without this bug fix, the generated OpenAPI document is incorrect and users run into an underlying bug in Swagger UI that causes certain requests to hang the Swagger UI.
Regression?
Risk
Low risk, because the impact area is restricted to users of the
Microsoft.AspNetCore.OpenApipackage and theWithOpenApiextension method. This change is not likely to have negative side effects since it updates the definition to be compliant with OpenAPI-requirements.Verification
Packaging changes reviewed?