Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Use IndexOfAnyValues in ForwardedHeadersMiddleware #47459

Merged
merged 3 commits into from Mar 29, 2023
Merged

Use IndexOfAnyValues in ForwardedHeadersMiddleware #47459

merged 3 commits into from Mar 29, 2023

Conversation

adityamandaleeka
Copy link
Member

Contributes to #46484

Updates the logic in ForwardedHeadersMiddleware dealing with host/port and scheme characters.

@ghost ghost added the area-runtime label Mar 28, 2023
JamesNK
JamesNK approved these changes Mar 28, 2023
View reviewed changes
Copy link
Member

@JamesNK JamesNK left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me, assuming there isn't an index off by one error we're missing.

What is unit testing like in this area?

@adityamandaleeka
Copy link
Member Author

Looks good to me, assuming there isn't an index off by one error we're missing.

What is unit testing like in this area?

Unit testing in this area is pretty good (as I learned while working on this and breaking tests 😄).

Feedback addressed.

@adityamandaleeka adityamandaleeka merged commit 3a6acd9 into dotnet:main Mar 29, 2023
26 checks passed
@ghost ghost added this to the 8.0-preview4 milestone Mar 29, 2023
@amcasey amcasey added area-middleware Includes: URL rewrite, redirect, response cache/compression, session, and other general middlesware and removed area-runtime labels Jun 2, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@gfoidl gfoidl gfoidl left review comments

@JamesNK JamesNK JamesNK approved these changes

@MihaZupan MihaZupan MihaZupan approved these changes

@Tratcher Tratcher Awaiting requested review from Tratcher

@BrennanConroy BrennanConroy Awaiting requested review from BrennanConroy BrennanConroy is a code owner

Assignees
No one assigned
Labels
area-middleware Includes: URL rewrite, redirect, response cache/compression, session, and other general middlesware Perf
Projects
None yet
Milestone
8.0-preview4
Development

Successfully merging this pull request may close these issues.

None yet
7 participants
@adityamandaleeka @JamesNK @gfoidl @MihaZupan @BrennanConroy @amcasey @mitchdenny