Diaganostics and metrics clean up #47679
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
JamesNK
requested review from
Tratcher,
halter73,
BrennanConroy and
mgravell
as code owners
JamesNK
commented
Apr 13, 2023
| @@ -221,8 +257,7 @@ private class TestHttpActivityFeature : IHttpActivityFeature | |||
| } | |||
|
|
|||
| [Fact] | |||
| [QuarantinedTest("https://github.com/dotnet/aspnetcore/issues/38736")] | |||
There was a problem hiding this comment.
This quarantined test has been removed.
JamesNK
commented
Apr 13, 2023
Comment on lines
+241
to
+243
| using var dummyActivity = dummySource.StartActivity("DummyActivity"); | ||
| Assert.NotNull(dummyActivity); | ||
| Assert.Equal(Activity.Current, dummyActivity); |
There was a problem hiding this comment.
Attempting to narrow down the cause of this flaky test.
JamesNK
force-pushed
the
jamesnk/metrics-cleanup
branch
from
b041e6c
to
d0554ea
Compare
|
Looks good so far, but will wait to approve until you've finished running down the flakey test. |
Don't need to hold up merging this.
|
mitchdenny
approved these changes
Apr 14, 2023
This reverts commit f17ba95.
ghost
added this to the 
amcasey
added
area-networking
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Some clean-up from #46834
Made
IHttpActivityFeatureandIHttpMetricsTagsFeaturebehave consistently. The "owner" of the features responsible for setting them is hosting. This allows us to have a source of truth implementation which means we can access the underlyingList<T>on metrics tags directly instead of going through the feature interface.Previously hosting would check if the server had an activity feature. Now, if the server sets the feature, it is overridden by hosting. This was probably done for testing. It's a change but very, very unlikely anyone would do this (implement a new server and choose to override
IHttpActivityFeature).