Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

IExceptionHandler for exception handler middleware #46280 #47923

Merged
merged 4 commits into from
Apr 28, 2023

Conversation

Kahbazi
Copy link
Member

@Kahbazi Kahbazi commented Apr 27, 2023

Fixes #46280

@ghost ghost added the community-contribution Indicates that the PR has been added by a community member label Apr 27, 2023
@ghost
Copy link

ghost commented Apr 27, 2023

Thanks for your PR, @Kahbazi. Someone from the team will get assigned to your PR shortly and we'll get it reviewed.

@Tratcher Tratcher self-assigned this Apr 27, 2023
@davidfowl
Copy link
Member

@Tratcher is there a reason you didn't merge this?

@davidfowl
Copy link
Member

davidfowl commented Apr 28, 2023

Do we have any plans to use this outside of the unit tests? (in the product itself) @Tratcher

@Tratcher Tratcher enabled auto-merge (squash) April 28, 2023 15:50
@Tratcher
Copy link
Member

I was just giving it a day for other reviews.

We haven't identified anywhere in the product we'd use this feature. I suppose we could refactor the BadHttpRequest and ProblemDetails handling to use it?

@davidfowl
Copy link
Member

We haven't identified anywhere in the product we'd use this feature. I suppose we could refactor the BadHttpRequest and ProblemDetails handling to use it?

Yes, I was hoping this would be the case.

@Tratcher Tratcher merged commit b2ce346 into dotnet:main Apr 28, 2023
26 checks passed
@ghost ghost added this to the 8.0-preview5 milestone Apr 28, 2023
@amcasey amcasey added area-middleware Includes: URL rewrite, redirect, response cache/compression, session, and other general middlesware and removed area-runtime labels Jun 6, 2023
@Tratcher Tratcher added the blog-candidate Consider mentioning this in the release blog post label Jun 7, 2023
@ghost
Copy link

ghost commented Jun 7, 2023

@Kahbazi, this change will be considered for inclusion in the blog post for the release it'll ship in. Nice work!

Please ensure that the original comment in this thread contains a clear explanation of what the change does, why it's important (what problem does it solve?), and, if relevant, include things like code samples and/or performance numbers.

This content may not be exactly what goes into the blog post, but it will help the team putting together the announcement.

Thanks!

@davidfowl
Copy link
Member

We haven't identified anywhere in the product we'd use this feature. I suppose we could refactor the BadHttpRequest and ProblemDetails handling to use it?

Can we track this @Tratcher ?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area-middleware Includes: URL rewrite, redirect, response cache/compression, session, and other general middlesware blog-candidate Consider mentioning this in the release blog post community-contribution Indicates that the PR has been added by a community member
Projects
None yet
Development

Successfully merging this pull request may close these issues.

IExceptionHandler for exception handler middleware
4 participants