Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update HttpLoggingAttribute API #48214

Merged
merged 2 commits into from
May 12, 2023
Merged

Update HttpLoggingAttribute API #48214

merged 2 commits into from
May 12, 2023

Conversation

BrennanConroy
Copy link
Member

Closes #43222

Tratcher
Tratcher approved these changes May 12, 2023
View reviewed changes
src/Middleware/HttpLogging/src/HttpLoggingAttribute.cs Outdated
{
return _responseBodyLogLimit;
}
throw new InvalidOperationException("TODO");
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Lol

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Oh no 😆

@BrennanConroy BrennanConroy merged commit 7db7dcd into main May 12, 2023
26 checks passed
@BrennanConroy BrennanConroy deleted the brecon/httplogging branch May 12, 2023 21:22
@ghost ghost added this to the 8.0-preview5 milestone May 12, 2023
@amcasey amcasey added area-middleware Includes: URL rewrite, redirect, response cache/compression, session, and other general middlesware and removed area-runtime labels Jun 2, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Tratcher Tratcher Tratcher approved these changes

Assignees
No one assigned
Labels
area-middleware Includes: URL rewrite, redirect, response cache/compression, session, and other general middlesware
Projects
None yet
Milestone
8.0-preview5
Development

Successfully merging this pull request may close these issues.

Make Http Logging Middleware Endpoint aware
3 participants
@BrennanConroy @Tratcher @amcasey