Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add WithOrder to IEndpointConventionBuilder #49093

Merged
merged 3 commits into from
Aug 9, 2023
Merged

Add WithOrder to IEndpointConventionBuilder #49093

merged 3 commits into from
Aug 9, 2023

Conversation

Kahbazi
Copy link
Member

@Kahbazi Kahbazi commented Jun 29, 2023

Add WithOrder to IEndpointConventionBuilder

Fixes #47579

@Kahbazi Kahbazi requested a review from javiercn as a code owner June 29, 2023 15:01
@ghost ghost added area-runtime community-contribution Indicates that the PR has been added by a community member labels Jun 29, 2023
@ghost
Copy link

ghost commented Jun 29, 2023

Thanks for your PR, @Kahbazi. Someone from the team will get assigned to your PR shortly and we'll get it reviewed.

@Tratcher Tratcher self-assigned this Jun 29, 2023
@ghost
Copy link

ghost commented Jul 7, 2023

Looks like this PR hasn't been active for some time and the codebase could have been changed in the meantime.
To make sure no breaking changes are introduced, please leave an /azp run comment here to rerun the CI pipeline and confirm success before merging the change.

@ghost ghost added the pending-ci-rerun When assigned to a PR indicates that the CI checks should be rerun label Jul 7, 2023
@Tratcher Tratcher enabled auto-merge (squash) August 9, 2023 18:03
@Tratcher Tratcher merged commit 498cd15 into dotnet:main Aug 9, 2023
26 checks passed
@ghost ghost added this to the 8.0-rc1 milestone Aug 9, 2023
@Tratcher
Copy link
Member

Tratcher commented Aug 9, 2023

Thanks @Kahbazi

@Kahbazi Kahbazi deleted the kahbazi/WithOrder branch August 12, 2023 13:34
@amcasey amcasey added area-networking Includes servers, yarp, json patch, bedrock, websockets, http client factory, and http abstractions and removed area-runtime labels Aug 25, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Tratcher Tratcher Tratcher approved these changes

@javiercn javiercn Awaiting requested review from javiercn javiercn is a code owner

Assignees

@Tratcher Tratcher

Labels
area-networking Includes servers, yarp, json patch, bedrock, websockets, http client factory, and http abstractions community-contribution Indicates that the PR has been added by a community member pending-ci-rerun When assigned to a PR indicates that the CI checks should be rerun
Projects
None yet
Milestone
8.0-rc1
Development

Successfully merging this pull request may close these issues.

Setting route order imperatively
3 participants
@Kahbazi @Tratcher @amcasey