Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Implement IDirectoryContents on ManifestDirectoryInfo #50586

Merged
merged 1 commit into from
Dec 11, 2023
Merged

Implement IDirectoryContents on ManifestDirectoryInfo #50586

merged 1 commit into from
Dec 11, 2023

Conversation

rameel
Copy link
Contributor

@rameel rameel commented Sep 8, 2023

As part of the changes made to the PhysicalFileProvider, the IFileInfo representing the directory should implement IDirectoryContents.

Issue: #86354
PR with changes: #91024

@dotnet-issue-labeler dotnet-issue-labeler bot added the area-mvc Includes: MVC, Actions and Controllers, Localization, CORS, most templates label Sep 8, 2023
@ghost ghost added the community-contribution Indicates that the PR has been added by a community member label Sep 8, 2023
@ghost
Copy link

ghost commented Sep 8, 2023

Thanks for your PR, @rameel. Someone from the team will get assigned to your PR shortly and we'll get it reviewed.

@rameel
Copy link
Contributor Author

rameel commented Sep 8, 2023

@dotnet-policy-service agree

@rameel rameel changed the title Implement IDirectoryContents on ManifestEmbeddedFileProvider Implement IDirectoryContents on ManifestDirectoryInfo Sep 8, 2023
@rameel rameel mentioned this pull request Sep 8, 2023
Merged
@mkArtakMSFT mkArtakMSFT added area-ui-rendering Includes: MVC Views/Pages, Razor Views/Pages and removed area-mvc Includes: MVC, Actions and Controllers, Localization, CORS, most templates labels Sep 13, 2023
@ghost
Copy link

ghost commented Sep 21, 2023

Looks like this PR hasn't been active for some time and the codebase could have been changed in the meantime.
To make sure no conflicting changes have occurred, please rerun validation before merging. You can do this by leaving an /azp run comment here (requires commit rights), or by simply closing and reopening.

@ghost ghost added the pending-ci-rerun When assigned to a PR indicates that the CI checks should be rerun label Sep 21, 2023
@rameel
Copy link
Contributor Author

rameel commented Sep 21, 2023

/azp run

@azure-pipelines
Copy link

Commenter does not have sufficient privileges for PR 50586 in repo dotnet/aspnetcore

@javiercn javiercn merged commit a2e6538 into dotnet:main Dec 11, 2023
25 checks passed
@ghost ghost added this to the 9.0-preview1 milestone Dec 11, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@javiercn javiercn javiercn approved these changes

Assignees

@javiercn javiercn

Labels
area-ui-rendering Includes: MVC Views/Pages, Razor Views/Pages community-contribution Indicates that the PR has been added by a community member pending-ci-rerun When assigned to a PR indicates that the CI checks should be rerun
Projects
None yet
Milestone
9.0-preview1
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@rameel @javiercn @mkArtakMSFT