Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

#52067 input number range type #52747

Closed

Conversation

jcreach
Copy link

@jcreach jcreach commented Dec 11, 2023

Added the ability to override the inputNumber component type

Add an inputRange component like the basic inputNumber components #52067

  • You've read the Contributor Guide and Code of Conduct.
  • You've included unit or integration tests for your change, where applicable.
  • You've included inline docs for your change, where applicable.
  • There's an open issue for the PR that you are making. If you'd like to propose a new feature or change, please open an issue to discuss the change or find an existing issue.

Summary of the changes (Less than 80 chars)

Description

Added the ability to override the inputNumber component type

Fixes #52067 (in this specific format)

Added the ability to override the inputNumber component type
@jcreach jcreach requested a review from a team as a code owner December 11, 2023 20:49
@ghost ghost added area-blazor Includes: Blazor, Razor Components community-contribution Indicates that the PR has been added by a community member labels Dec 11, 2023
@ghost
Copy link

ghost commented Dec 11, 2023

Thanks for your PR, @jcreach. Someone from the team will get assigned to your PR shortly and we'll get it reviewed.

@ghost ghost added the pending-ci-rerun When assigned to a PR indicates that the CI checks should be rerun label Dec 20, 2023
Copy link
Member

@mkArtakMSFT mkArtakMSFT left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @jcreach.

@javiercn can you point @jcreach to an example or two of unit-tests validating similar functionality, so that @jcreach can add some tests with this change? Thanks!

@jcreach
Copy link
Author

jcreach commented Feb 12, 2024

Thank you @mkArtakMSFT for your feedback.
@javiercn doesn't seem to be available to take over the point. Is there anyone else available? 😄

Thanks!

@javiercn
Copy link
Member

Sample E2E test

public class FormsInputDateTest : ServerTestBase<ToggleExecutionModeServerFixture<Program>>

Sample Unit test
https://github.com/dotnet/aspnetcore/blob/002b186d22a162fce4fc3faea17a8d7f3db74541/src/Components/Web/test/Forms/InputDateTest.cs

@wtgodbe wtgodbe removed the pending-ci-rerun When assigned to a PR indicates that the CI checks should be rerun label Feb 13, 2024
@dotnet dotnet deleted a comment Feb 13, 2024
@dotnet-policy-service dotnet-policy-service bot added the area-infrastructure Includes: MSBuild projects/targets, build scripts, CI, Installers and shared framework label Feb 13, 2024
@wtgodbe wtgodbe removed the area-infrastructure Includes: MSBuild projects/targets, build scripts, CI, Installers and shared framework label Feb 13, 2024
Copy link
Contributor

Looks like this PR hasn't been active for some time and the codebase could have been changed in the meantime.
To make sure no conflicting changes have occurred, please rerun validation before merging. You can do this by leaving an /azp run comment here (requires commit rights), or by simply closing and reopening.

@dotnet-policy-service dotnet-policy-service bot added the pending-ci-rerun When assigned to a PR indicates that the CI checks should be rerun label Feb 20, 2024
@javiercn javiercn added the pr: pending author input For automation. Specifically separate from Needs: Author Feedback label Feb 20, 2024
@dotnet-policy-service dotnet-policy-service bot added the stale Indicates a stale issue. These issues will be closed automatically soon. label Mar 1, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area-blazor Includes: Blazor, Razor Components community-contribution Indicates that the PR has been added by a community member pending-ci-rerun When assigned to a PR indicates that the CI checks should be rerun pr: pending author input For automation. Specifically separate from Needs: Author Feedback stale Indicates a stale issue. These issues will be closed automatically soon.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add an inputRange component like the basic inputNumber components
4 participants