Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

SignalR performance: track groups per connection, remove on disconnect #53486

Merged
merged 10 commits into from
Feb 7, 2024
Merged

SignalR performance: track groups per connection, remove on disconnect #53486

merged 10 commits into from
Feb 7, 2024

Commits on Jan 19, 2024

  1. SignalR: track groups per connection, remove on disconnect, fixes dot… 

    …net#48249

Instead of iterating over ALL the groups, which is slow and even introduces a DDoS vector, we remove from groups that are specific to this connection
    @alex-jitbit
    alex-jitbit committed Jan 19, 2024
    Configuration menu
    Copy the full SHA
    f42e27b View commit details
    Browse the repository at this point in the history

  2. Removed unused method

    @alex-jitbit
    alex-jitbit committed Jan 19, 2024
    Configuration menu
    Copy the full SHA
    ea2878a View commit details
    Browse the repository at this point in the history

Commits on Jan 22, 2024

  1. Apply suggestions from code review 

    Co-authored-by: Brennan <brecon@microsoft.com>
    @alex-jitbit @BrennanConroy
    alex-jitbit and BrennanConroy committed Jan 22, 2024
    Configuration menu
    Copy the full SHA
    689d83e View commit details
    Browse the repository at this point in the history

  2. More code review suggestions with a minor fix

    @alex-jitbit
    alex-jitbit committed Jan 22, 2024
    Configuration menu
    Copy the full SHA
    9cccb00 View commit details
    Browse the repository at this point in the history

  3. Use lock instead of ToArray (the latter iterates anyway)

    @alex-jitbit
    alex-jitbit committed Jan 22, 2024
    Configuration menu
    Copy the full SHA
    2cc1b9d View commit details
    Browse the repository at this point in the history

Commits on Jan 24, 2024

  1. Made the HashSet an internal property on HubConnectionContext

    @alex-jitbit
    alex-jitbit committed Jan 24, 2024
    Configuration menu
    Copy the full SHA
    a0bd193 View commit details
    Browse the repository at this point in the history

  2. Removed unneeded "using"

    @alex-jitbit
    alex-jitbit committed Jan 24, 2024
    Configuration menu
    Copy the full SHA
    2dbcdc0 View commit details
    Browse the repository at this point in the history

Commits on Jan 27, 2024

  1. Removed ignore-case from group tracking

    @alex-jitbit
    alex-jitbit committed Jan 27, 2024
    Configuration menu
    Copy the full SHA
    75081bc View commit details
    Browse the repository at this point in the history

Commits on Feb 3, 2024

  1. Merge branch 'dotnet:main' into main

    @alex-jitbit
    alex-jitbit committed Feb 3, 2024
    Configuration menu
    Copy the full SHA
    19d7bbb View commit details
    Browse the repository at this point in the history

  2. Addressed race condition from code review

    @alex-jitbit
    alex-jitbit committed Feb 3, 2024
    Configuration menu
    Copy the full SHA
    995fb9d View commit details
    Browse the repository at this point in the history