Introduce a read-only mode for data protection keyring consumers #53539
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
When multiple app instances consume the same keyring, they all try to rotate it, leading to races. This change introduces an IConfiguration property (usually set as an env var) that puts data protection in a read-only mode. The expectation is that writing will be done by a separate (i.e. non-app-instance) component. Part of dotnet#52915
|
Chris pointed out that |
Tratcher
reviewed
Jan 22, 2024
src/DataProtection/DataProtection/src/Internal/KeyManagementOptionsPostSetup.cs
Show resolved
Hide resolved
Tratcher
reviewed
Jan 22, 2024
src/DataProtection/DataProtection/src/Internal/KeyManagementOptionsPostSetup.cs
Outdated
Show resolved
Hide resolved
Tratcher
reviewed
Jan 22, 2024
Co-authored-by: Chris Ross <Tratcher@Outlook.com>
Tratcher
approved these changes
Jan 23, 2024
...test/Microsoft.AspNetCore.DataProtection.Tests/Internal/KeyManagementOptionsPostSetupTest.cs
Show resolved
Hide resolved
|
Interesting - the failure is specific to *nix. Investigating. |
1 task
ghost
added
the
area-infrastructure
|
/backport to branch release/8.0 |
|
Started backporting to branch: https://github.com/dotnet/aspnetcore/actions/runs/8088872298 |
|
@amcasey an error occurred while backporting to branch, please check the run log for details! Error: The specified backport target branch branch wasn't found in the repo. |
|
/backport to release/8.0 |
|
Started backporting to release/8.0: https://github.com/dotnet/aspnetcore/actions/runs/8088881925 |
10 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Introduce a read-only mode for data protection keyring consumers
Description
When multiple app instances consume the same keyring, they all try to rotate it, leading to races. This change introduces an IConfiguration property (usually set as an env var) that puts data protection in a read-only mode. The expectation is that writing will be done by a separate (i.e. non-app-instance) component.
Fixes #52915