Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[release/8.0] Introduce a read-only mode for data protection keyring consumers #54266

Merged
merged 9 commits into from
Mar 6, 2024
Merged

[release/8.0] Introduce a read-only mode for data protection keyring consumers #54266

merged 9 commits into from
Mar 6, 2024

Commits on Feb 29, 2024

  1. Introduce a read-only mode for data protection keyring consumers 

    When multiple app instances consume the same keyring, they all try to rotate it, leading to races.  This change introduces an IConfiguration property (usually set as an env var) that puts data protection in a read-only mode.  The expectation is that writing will be done by a separate (i.e. non-app-instance) component.

Part of #52915
    @amcasey
    amcasey authored and github-actions committed Feb 29, 2024
    Configuration menu
    Copy the full SHA
    d8b6a29 View commit details
    Browse the repository at this point in the history

  2. Add simple tests

    @amcasey
    amcasey authored and github-actions committed Feb 29, 2024
    Configuration menu
    Copy the full SHA
    183d862 View commit details
    Browse the repository at this point in the history

  3. Handle an empty path

    @amcasey
    amcasey authored and github-actions committed Feb 29, 2024
    Configuration menu
    Copy the full SHA
    96af285 View commit details
    Browse the repository at this point in the history

  4. Add logging

    @amcasey
    amcasey authored and github-actions committed Feb 29, 2024
    Configuration menu
    Copy the full SHA
    e974538 View commit details
    Browse the repository at this point in the history

  5. Increase positive-case log level 

    Co-authored-by: Chris Ross <Tratcher@Outlook.com>
    @amcasey @Tratcher
    2 people authored and github-actions committed Feb 29, 2024
    Configuration menu
    Copy the full SHA
    c9ffe1b View commit details
    Browse the repository at this point in the history

  6. Fix style warning

    @amcasey
    amcasey authored and github-actions committed Feb 29, 2024
    Configuration menu
    Copy the full SHA
    a83815f View commit details
    Browse the repository at this point in the history

  7. Add an AddDataProtection test

    @amcasey
    amcasey authored and github-actions committed Feb 29, 2024
    Configuration menu
    Copy the full SHA
    b40f9f2 View commit details
    Browse the repository at this point in the history

  8. Add a negative AddDataProtection test

    @amcasey
    amcasey authored and github-actions committed Feb 29, 2024
    Configuration menu
    Copy the full SHA
    b84c559 View commit details
    Browse the repository at this point in the history

  9. Use a directory that exists in ConfigureReadOnly_ExplicitRepository

    @amcasey
    amcasey authored and github-actions committed Feb 29, 2024
    Configuration menu
    Copy the full SHA
    f6f506d View commit details
    Browse the repository at this point in the history