Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Improve Kestrel connection metrics with error reasons #55565
base: main
Are you sure you want to change the base?
Improve Kestrel connection metrics with error reasons #55565
Changes from all commits
5757399
0e13256
8d923c8
1a3585c
a56188f
c094c7c
a318f4b
7ecab1e
65fa80d
35e2330
91dd2c8
60da8af
b9e1e18
0b6cfbe
a14c364
fefe6ab
6ed61b7
deca079
91f8627
6217252
8e0469d
843e54d
bc32fcb
6418e1d
9b036f4
File filter
Filter by extension
Conversations
Jump to
There are no files selected for viewing
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@halter73 @Tratcher It would be good to get your thoughts on whether new connection end reasons should be added based on available
RequestRejectionReason
values thrown when parsing a 1.1 request.There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Maybe for the more common ones that aren't just buggy clients like
UnexpectedEndOfRequestContent
RequestBodyTooLarge
RequestBodyTimeout