Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Enable input number component to support type='range' attribute #55583

Open
wants to merge 13 commits into
base: main
Choose a base branch
from
Open

Enable input number component to support type='range' attribute #55583

wants to merge 13 commits into from

Commits on May 7, 2024

  1. Commit modifies the InputNumber component to allow the 'type' attribu… 

    …te specified by the user to take precedence over the default 'type="number"'. By swapping the order in which attributes are added to the builder, any user-defined 'type' attribute is now respected, enabling the usage of different input types like 'range'.

Previously, the InputNumber component hardcoded the 'type' attribute as 'number', which prevented using it for other input types such as sliders (range inputs).
    @MattyLeslie
    MattyLeslie committed May 7, 2024
    Configuration menu
    Copy the full SHA
    ca712c1 View commit details
    Browse the repository at this point in the history

  2. Adding a test to the inputNumberTests to ensure the user defined type… 

    … attribute overrides the default.
    @MattyLeslie
    MattyLeslie committed May 7, 2024
    Configuration menu
    Copy the full SHA
    f9ceb16 View commit details
    Browse the repository at this point in the history

  3. Merge branch 'dotnet:main' into Enable-InputNumber-Component-to-Suppo… 

    …rt-type='range'-Attribute
    @MattyLeslie
    MattyLeslie committed May 7, 2024
    Configuration menu
    Copy the full SHA
    525b346 View commit details
    Browse the repository at this point in the history

  4. Using the TestRederer to extract attributes and assert the user-defin… 

    …ed type override the default
    @MattyLeslie
    MattyLeslie committed May 7, 2024
    Configuration menu
    Copy the full SHA
    bfa7733 View commit details
    Browse the repository at this point in the history

  5. Merge branch 'Enable-InputNumber-Component-to-Support-type='range'-At… 

    …tribute' of https://github.com/MattyLeslie/aspnetcore into Enable-InputNumber-Component-to-Support-type='range'-Attribute
    @MattyLeslie
    MattyLeslie committed May 7, 2024
    Configuration menu
    Copy the full SHA
    ce3d8c0 View commit details
    Browse the repository at this point in the history

Commits on May 8, 2024

  1. Retrieving frames with new methodology

    @MattyLeslie
    MattyLeslie committed May 8, 2024
    Configuration menu
    Copy the full SHA
    8df498d View commit details
    Browse the repository at this point in the history

Commits on May 9, 2024

  1. Isolating the correct element to extract attributes from

    @MattyLeslie
    MattyLeslie committed May 9, 2024
    Configuration menu
    Copy the full SHA
    c7a76af View commit details
    Browse the repository at this point in the history

  2. Only asserting the type attribute = range

    @MattyLeslie
    MattyLeslie committed May 9, 2024
    Configuration menu
    Copy the full SHA
    ac09491 View commit details
    Browse the repository at this point in the history

Commits on May 14, 2024

  1. Isolating input element, atrributes and type attribute correctly

    @MattyLeslie
    MattyLeslie committed May 14, 2024
    Configuration menu
    Copy the full SHA
    dd6b779 View commit details
    Browse the repository at this point in the history

Commits on May 15, 2024

  1. Improving methodology of handling render tree frames and isolating th… 

    …e input element and attributes
    @MattyLeslie
    MattyLeslie committed May 15, 2024
    Configuration menu
    Copy the full SHA
    7b2ee01 View commit details
    Browse the repository at this point in the history

Commits on May 20, 2024

  1. Ammendments to tests

    @MattyLeslie
    MattyLeslie committed May 20, 2024
    Configuration menu
    Copy the full SHA
    ebf82de View commit details
    Browse the repository at this point in the history

Commits on May 28, 2024

  1. Merge branch 'dotnet:main' into Enable-InputNumber-Component-to-Suppo… 

    …rt-type='range'-Attribute
    @MattyLeslie
    MattyLeslie committed May 28, 2024
    Configuration menu
    Copy the full SHA
    af90057 View commit details
    Browse the repository at this point in the history

Commits on May 30, 2024

  1. Merge branch 'dotnet:main' into Enable-InputNumber-Component-to-Suppo… 

    …rt-type='range'-Attribute
    @MattyLeslie
    MattyLeslie committed May 30, 2024
    Configuration menu
    Copy the full SHA
    d1f916e View commit details
    Browse the repository at this point in the history