Remove Microsoft.AspNet.WebApi.Client and Newtonsoft.Json.Bson from shared fx #6552
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
natemcmaster
added
the
breaking-change
Eilon
approved these changes
Jan 10, 2019
|
I've added this assembly to the list in #3755. From our internal discussions, this assembly has a dependency on Newtonsoft.Json. It is our goal by the time 3.0 ships to remove Newtonsoft.Json from Microsoft.AspNetCore.App. It's unclear how we could replace Microsoft.AspNet.WebApi.Client's dependency on Newtonsoft.Json, so we are preemptively removing it for 3.0 Preview 2. We will continue to investigate a replacement. In the meantime, users calling the APIs this assembly provides should add a package reference to Microsoft.AspNet.WebApi.Client. |
natemcmaster
approved these changes
Jan 10, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.