Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Make ComponentFactory public and register it in the IServiceCollection #7967

Closed
wants to merge 1 commit into from
Closed

Make ComponentFactory public and register it in the IServiceCollection #7967

wants to merge 1 commit into from

Conversation

CatoLeanTruetschel
Copy link

  • Changed access modifier of ComponentFactory to public
  • Added an interface IComponentFactory
  • Registered the ComponentFactory in the service collection as service IComponentFactory

Addresses #7962

@dnfclas
Copy link

dnfclas commented Feb 26, 2019 •
edited

CLA assistant check
All CLA requirements met.

@Eilon Eilon added the area-mvc Includes: MVC, Actions and Controllers, Localization, CORS, most templates label Feb 26, 2019
@pranavkm pranavkm added area-blazor Includes: Blazor, Razor Components and removed area-mvc Includes: MVC, Actions and Controllers, Localization, CORS, most templates labels Aug 24, 2019
@pranavkm pranavkm added this to the 5.0.0-preview1 milestone Aug 24, 2019
@mkArtakMSFT
Copy link
Member

Thanks for your PR. We're closing this per #7962 (comment)

@mkArtakMSFT mkArtakMSFT closed this Sep 4, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@SteveSandersonMS SteveSandersonMS Awaiting requested review from SteveSandersonMS

Assignees

@SteveSandersonMS SteveSandersonMS

Labels
area-blazor Includes: Blazor, Razor Components
Projects
None yet
Milestone
5.0.0-preview1
Development

Successfully merging this pull request may close these issues.

None yet
6 participants
@CatoLeanTruetschel @dnfclas @mkArtakMSFT @pranavkm @Eilon @SteveSandersonMS