Skip to content
This repository has been archived by the owner on Jan 11, 2024. It is now read-only.

Fix paths coverage and report tools #156

Merged
merged 1 commit into from
May 6, 2015

Conversation

mmitche
Copy link
Member

@mmitche mmitche commented May 6, 2015

/cc @stephentoub @AlfredoMS

@ericstj I think this is related to your build tools updates. Can you take a look?

@dnfclas
Copy link

dnfclas commented May 6, 2015

Hi @mmitche, I'm your friendly neighborhood .NET Foundation Pull Request Bot (You can call me DNFBOT). Thanks for your contribution!
You've already signed the contribution license agreement. Thanks!

The agreement was validated by .NET Foundation and real humans are currently evaluating your PR.

TTYL, DNFBOT;

@stephentoub
Copy link
Member

LGTM. Thanks for fixing it.

@ericstj
Copy link
Member

ericstj commented May 6, 2015

Ah, indeed nuget v3 changes the package cache structure. I did fix the cases of this that I knew about in System.IO.Compression but was unaware that it was happening here as well. Long term it might make sense to ask nuget to resolve these paths for you and avoid the hardcoding.

@mmitche
Copy link
Member Author

mmitche commented May 6, 2015

@ericstj How much work is involved in that or can you point me to an example?

mmitche added a commit that referenced this pull request May 6, 2015
Fix paths coverage and report tools
@mmitche mmitche merged commit 7e6ddcd into dotnet:master May 6, 2015
@mmitche mmitche deleted the coverage-package-fixes branch May 6, 2015 16:21
@ericstj
Copy link
Member

ericstj commented May 6, 2015

@mmitche have a look at what @mellinoe is doing for partial facades in FindPartialFacadeContractReference. https://github.com/dotnet/buildtools/blob/master/src/Microsoft.DotNet.Build.Tasks/Targets/partialfacades.targets

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants