This repository has been archived by the owner on Jan 11, 2024. It is now read-only.
Adding scripts that will bootstrap netcore msbuild and that can be called from repos. Also switching forward slashes to backslashes for OS X build. #396
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| @@ -74,11 +74,12 @@ | |||
| <ItemGroup> | |||
| <!-- Need to escape double forward slash (%2F) or MSBuild will normalize to one slash on Unix. --> | |||
| <DnuSourceList Include="https:%2F%2Fwww.myget.org/F/dotnet-core/" /> | |||
| <DnuSourceList Include="https:%2F%2Fwww.myget.org/F/roslyn-nightly/" /> | |||
This comment was marked as spam.
This comment was marked as spam.
Sorry, something went wrong.
This comment was marked as spam.
This comment was marked as spam.
Sorry, something went wrong.
joperezr
force-pushed
the
RestoreNetCoreMSBuild
branch
4 times, most recently
from
b91f4f7
to
11aedda
Compare
joperezr
force-pushed
the
RestoreNetCoreMSBuild
branch
from
98595e5
to
c02dcb2
Compare
joperezr
changed the title
|
With my latest change, I've now removed the roslyn and the local feed for the restore since I have succesfully uploaded all required packages into buildtools feed, this means that CI should pass now, and that this PR is ready to be merge once feedback is done. |
| @@ -6,6 +6,7 @@ set DOTNET_CMD=%~2 | |||
| set TOOLRUNTIME_DIR=%~3 | |||
| IF [%BUILDTOOLS_TARGET_RUNTIME%]==[] set BUILDTOOLS_TARGET_RUNTIME=win7-x64 | |||
| set BUILDTOOLS_PACKAGE_DIR=%~dp0 | |||
| set MSBUILD_CONTENT_JSON={"dependencies": {"Microsoft.Portable.Targets": "0.1.1-dev"},"frameworks": {"dnxcore50": {},"net46": {}}} | |||
This comment was marked as spam.
This comment was marked as spam.
Sorry, something went wrong.
This comment was marked as spam.
This comment was marked as spam.
Sorry, something went wrong.
|
LGTM but please be sure to file the extra tracking issues for follow-up work. |
joperezr
added a commit
that referenced
this pull request
Jan 27, 2016
Adding scripts that will bootstrap netcore msbuild and that can be called from repos. Also switching forward slashes to backslashes for OS X build.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
[DO NOT MERGE YET] Adding scripts that will bootstrap netcore msbuild and that can be called from repos