Fix portable PDB stamp in CodeView header #32
Merged
+35
−13
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Previous fix for deterministic PDB ID wrote the PDB stamp as the PDB Age field. This change fixes it to write the stamp as the stamp field of the CodeView header and writes the PDB Age as 1 always.
Added tests.
Also includes a test fix which was discovered by trying to merge the previous change into jbevain/cecil.