Add block thread constructor

dotnet · Jul 26, 2017 · c859035 · c859035
1 parent 6541a16
commit c859035
Show file tree

Hide file tree

Showing 2 changed files with 25 additions and 3 deletions.
diff --git a/src/dotnet/Telemetry.cs b/src/dotnet/Telemetry.cs
@@ -53,6 +53,28 @@ public Telemetry(IFirstTimeUseNoticeSentinel sentinel, string sessionId)
             _trackEventTask = Task.Factory.StartNew(() => InitializeTelemetry());
         }
 
+        public Telemetry(IFirstTimeUseNoticeSentinel sentinel, string sessionId, bool blockThreadInitialization)
+        {
+            Enabled = !Env.GetEnvironmentVariableAsBool(TelemetryOptout) && PermissionExists(sentinel);
+
+            if (!Enabled)
+            {
+                return;
+            }
+
+            // Store the session ID in a static field so that it can be reused
+            CurrentSessionId = sessionId ?? Guid.NewGuid().ToString();
+
+            if (blockThreadInitialization)
+            {
+                InitializeTelemetry();
+            }
+            else
+            {
+                _trackEventTask = Task.Factory.StartNew(() => InitializeTelemetry());
+            }
+        }
+
         private bool PermissionExists(IFirstTimeUseNoticeSentinel sentinel)
         {
             if (sentinel == null)
@@ -126,9 +148,9 @@ private void TrackEventTask(string eventName, IDictionary<string, string> proper
                 _client.TrackEvent(eventName, eventProperties, eventMeasurements);
                 _client.Flush();
             }
-            catch (Exception)
+            catch (Exception e)
             {
-                Debug.Fail("Exception during TrackEventTask");
+                Debug.Fail(e.ToString());
             }
         }
 

diff --git a/...tnet/commands/dotnet-internal-reportinstallsuccess/InternalReportinstallsuccessCommand.cs b/...tnet/commands/dotnet-internal-reportinstallsuccess/InternalReportinstallsuccessCommand.cs
@@ -43,7 +43,7 @@ internal ThreadBlockingTelemetry()
             {
                 var sessionId =
                 Environment.GetEnvironmentVariable(TelemetrySessionIdEnvironmentVariableName);
-                telemetry = new Telemetry(new NoOpFirstTimeUseNoticeSentinel(), sessionId);
+                telemetry = new Telemetry(new NoOpFirstTimeUseNoticeSentinel(), sessionId, blockThreadInitialization: true);
             }
             public bool Enabled => telemetry.Enabled;