Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

First run experience breaks parsing of dotnet --version #6403

Closed
livarcocc opened this issue Jun 13, 2016 · 4 comments
Closed

First run experience breaks parsing of dotnet --version #6403

livarcocc opened this issue Jun 13, 2016 · 4 comments
Assignees
Labels

Comments

@livarcocc
Copy link
Contributor

Steps to reproduce

Run dotnet --version

Expected behavior

To just have the version of the CLI in the output.

Actual behavior

We will print the EULA and the offline progress in the output and after that the version, which means that things that rely on simply getting the version out of this command will fail.

We need to consider if we want to skip the First Run experience in some cases for the CLI and we need to decide exactly which those cases are.

cc @blackdwarf @piotrpMSFT @ericstj

@brthor
Copy link
Contributor

brthor commented Jun 13, 2016

Perhaps we only launch first run experience when/if you are also launching a verb? dotnet new for example

@TheRealPiotrP
Copy link
Contributor

@livarcocc we need to do either what @brthor suggested or just special case --version and --info.

@eerhardt
Copy link
Member

Is this as simple as moving this call:

https://github.com/dotnet/cli/blob/rel/1.0.0-preview2/src/dotnet/Program.cs#L58

to this line:

https://github.com/dotnet/cli/blob/rel/1.0.0-preview2/src/dotnet/Program.cs#L127

?

Basically --help, --info, --version don't get the "first run" experience.

@brthor
Copy link
Contributor

brthor commented Jun 14, 2016

Spoke with @piotrpMSFT offline and it seems there might be more intricacy in ensuring telemetry doesn't run before the message has been shown

@Priya91 Priya91 assigned Priya91 and unassigned livarcocc Jun 14, 2016
@msftgits msftgits transferred this issue from dotnet/cli Jan 31, 2020
@msftgits msftgits added this to the 1.0.0-preview2 milestone Jan 31, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

6 participants