Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

dotnet-resgen #4334

Closed
davidfowl opened this issue Oct 18, 2015 · 9 comments
Closed

dotnet-resgen #4334

davidfowl opened this issue Oct 18, 2015 · 9 comments
Milestone

Comments

@davidfowl
Copy link
Member

https://msdn.microsoft.com/en-us/library/ccec7sz1(v=vs.110).aspx

We're going to need to either port resgen to coreclr or just write a new command that replicates some of the functionality. Today in the DNX we replicate some of it and pass data to the roslyn APIs. I'd imagine compile would work like this:

dotnet-compile /foo/project.json
dotnet-resgen /foo/project.json
resgen /foo/Resources.resx
resgen /foo/Resources2.resx
dotnet-compile-csc /foo/bin/dnxcore50/dotnet-compile.csc.rsp

I ran into this while trying to compile nuget with dotnet compile

@davidfowl
Copy link
Member Author

I'm going to put something temporary together for the sake of dnu parity but we need to think about the responsibilities of each of the tools. The steps are:

  • Get the list of resources
  • Convert resx -> .resources in a temp folder (or intermediate folder)
  • Gather .resources and embedded resources as compiler arguments
  • As part of the conversion, the logical name inferred from the file names are usually language specific (C#/VB etc). We could hand wave this for now but it's worth a mention.

@fearthecowboy
Copy link

Does this (or will it one day) provide the second feature of ResGen, that is, to create the strongly typed classes (either generating the .cs files or just emit the code) ?

(Desperately to know :) )

@TheRealPiotrP
Copy link
Contributor

This tool needs to be renamed dotnet-resgen until it's at parity with resgen. It's clashing on paths.

@TheRealPiotrP
Copy link
Contributor

@davidfowl what's left here for Beta milestone?

@andyleejordan
Copy link
Member

@davidfowl @piotrpMSFT Will strongly typed classes be part of the beta milestone?

@TheRealPiotrP
Copy link
Contributor

Beta is basically done. We will be branching soon.

@andyleejordan
Copy link
Member

@davidfowl What's the status on strongly typed class generation? I thought we were tracking that here, shall I make a new issue?

@davidfowl
Copy link
Member Author

Yes, make a new one.

@andyleejordan
Copy link
Member

I think dotnet/cli#819 is it.

wli3 referenced this issue in wli3/cli Jul 14, 2017
@msftgits msftgits transferred this issue from dotnet/cli Jan 31, 2020
@msftgits msftgits added this to the Backlog milestone Jan 31, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

5 participants