This repository has been archived by the owner on Apr 20, 2023. It is now read-only.
[release/3.1.1xx] Update dependencies from nuget/nuget.client #13042
Merged
wtgodbe
merged 6 commits into
release/3.1.1xx
from
darc-release/3.1.1xx-b0738cfb-cc8e-41df-b113-e44bac53fc4a
Nov 11, 2019
Merged
[release/3.1.1xx] Update dependencies from nuget/nuget.client #13042
wtgodbe
merged 6 commits into
release/3.1.1xx
from
darc-release/3.1.1xx-b0738cfb-cc8e-41df-b113-e44bac53fc4a
Nov 11, 2019
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…5.4.0.6292 - NuGet.Build.Tasks - 5.4.0-rtm.6292
Auto-Merge StatusThis pull request has not been merged because Maestro++ is waiting on the following merge policies.
|
We're hitting the OSX machine config issue in tests here (DOTNET_ROOT). @livarcocc @nguerrera @dsplaisted @wli3 who can take a look at this? |
Auto-Merge StatusThis pull request has not been merged because Maestro++ is waiting on the following merge policies.
|
4 tasks
0fed8b8 should do it (hopefully) |
Auto-Merge StatusThis pull request has not been merged because Maestro++ is waiting on the following merge policies.
|
This was referenced Nov 11, 2019
nguerrera
approved these changes
Nov 11, 2019
wli3
reviewed
Nov 11, 2019
@@ -148,7 +148,7 @@ private Process CreateProcess(string executable, string args) | |||
RemoveCliGeneratedEnvironmentVariablesFrom(psi); | |||
|
|||
// Set DOTNET_ROOT to ensure sub process find the same host fxr | |||
string dotnetDirectoryPath = Path.GetDirectoryName(new RepoDirectoriesProvider().DotnetRoot); | |||
string dotnetDirectoryPath = new RepoDirectoriesProvider().DotnetRoot; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@wtgodbe this should be right now
wtgodbe
deleted the
darc-release/3.1.1xx-b0738cfb-cc8e-41df-b113-e44bac53fc4a
branch
November 11, 2019 21:45
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pull request updates the following dependencies
From https://github.com/NuGet/NuGet.Client