Skip to content
This repository has been archived by the owner on Apr 20, 2023. It is now read-only.

dotnet-build3 Adding msbuild execution command to cli #3680

Merged
merged 1 commit into from Jun 23, 2016

Conversation

brthor
Copy link

@brthor brthor commented Jun 22, 2016

New PR targetting the feature branch.

Took a cleaning pass, please take a look.

@brthor
Copy link
Author

brthor commented Jun 22, 2016

@brthor
Copy link
Author

brthor commented Jun 22, 2016

@dotnet-bot test OpenSUSE13.2 x64 Debug Build please

@@ -6,5 +6,7 @@
<add key="dotnet-core" value="https://dotnet.myget.org/F/dotnet-core/api/v3/index.json" />
<add key="cli-deps" value="https://dotnet.myget.org/F/cli-deps/api/v3/index.json" />
<add key="api.nuget.org" value="https://api.nuget.org/v3/index.json" />
<add key="myget.org dotnet-buildtools" value="https://dotnet.myget.org/F/dotnet-buildtools/api/v3/index.json" />
<add key="myget.org nugetbuildtasks netcore" value="https://myget.org/F/brthor-netcore-testpackages/api/v3/index.json" />

This comment was marked as spam.

This comment was marked as spam.

This comment was marked as spam.

@eerhardt
Copy link
Member

using Microsoft.DotNet.Cli.Utils;

copyright on all new files.


Refers to: src/dotnet/commands/dotnet-build3/ForwardingApp.cs:1 in 9a7aacf. [](commit_id = 9a7aacf, deletion_comment = False)

"Microsoft.DotNet.Cli.Utils": {
"target": "project"
},
"Newtonsoft.Json": "9.0.1",

This comment was marked as spam.


namespace Microsoft.DotNet.Cli
{
public class MSBuildForwardingApp : ForwardingApp

This comment was marked as spam.

This comment was marked as spam.

@brthor brthor force-pushed the brthor/dotnet-msbuild branch 3 times, most recently from 8b2b0a6 to e252f61 Compare June 23, 2016 02:01
@eerhardt
Copy link
Member

:shipit:

<PlatformTarget Condition=" '$(PlatformTarget)' == '' ">x64</PlatformTarget>
<OutputType>Exe</OutputType>
<RootNamespace>MSBuildTestApp</RootNamespace>
<AssemblyName>$(MSBuildThisFileName)</AssemblyName>

This comment was marked as spam.

@brthor
Copy link
Author

brthor commented Jun 23, 2016

@dotnet-bot test this please

@brthor
Copy link
Author

brthor commented Jun 23, 2016

we have some green! Final failures are due to tests on release configuration, updated with fix.

@@ -11,6 +11,10 @@
"runtimes": {
"win7-x64": {},
"win7-x86": {},
"win81-x64": {},

This comment was marked as spam.

This comment was marked as spam.

This comment was marked as spam.

@brthor brthor merged commit c90287e into dotnet:feature/msbuild Jun 23, 2016
@brthor brthor deleted the brthor/dotnet-msbuild branch June 23, 2016 22:06
@brthor brthor restored the brthor/dotnet-msbuild branch June 24, 2016 23:52
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
8 participants