Skip to content
This repository has been archived by the owner on Apr 20, 2023. It is now read-only.

Base Prepare Infrastructure #3706

Merged
merged 1 commit into from Jun 27, 2016
Merged

Base Prepare Infrastructure #3706

merged 1 commit into from Jun 27, 2016

Conversation

brthor
Copy link

@brthor brthor commented Jun 27, 2016

Extracting this from #3696 so everyone can take advantage of the base work I needed to do for package targets.

Included is:

  • A task to get the current rid
  • A task to get the current arch
  • A task to generate an itemgroup with the build version info in metadata
  • base properties in prepare targets needed in other places

@eerhardt @sokket @livarcocc @piotrpMSFT

@jonmill
Copy link

jonmill commented Jun 27, 2016

LGTM! Thanks for putting this out there

eerhardt
eerhardt reviewed Jun 27, 2016
View reviewed changes
build/Microsoft.DotNet.Cli.Prepare.targets

<!-- Common Properties -->
<PropertyGroup>
<RepoRoot>$(MSBuildThisFileDirectory)/..</RepoRoot>

This comment was marked as spam.

Sign in to view

@eerhardt
Copy link
Member

:shipit:

@brthor brthor merged commit 219d9d2 into dotnet:feature/msbuild Jun 27, 2016
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
4 participants
@brthor @jonmill @eerhardt @dnfclas