This repository has been archived by the owner on Apr 20, 2023. It is now read-only.
Update README.md #3904
Merged
Update README.md #3904
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| As it was explained in the ["Changes to project.json" blog post](https://blogs.msdn.microsoft.com/dotnet/2016/05/23/changes-to-project-json/), we are making significant changes to the CLI tooling by supporting MSBuild as the build engine and `csproj` as the project format. As we are starting that work, we've realized that this also means that many of the shortcomings of the current tooling will be solved by this move. Given this, we've decided to introduce two new labels for issues to indicate that. These labels are: | ||
|
|
||
| * `msbuild-mitigated` label - this label indicates that we belive the issue in question will be mitigated via move to MSBuild. | ||
| * `msbuild-notapplicable` label - this label indicates that we believe the issue in question is will not be applicable after the move to MSBuild. |
This comment was marked as spam.
This comment was marked as spam.
Sorry, something went wrong.
|
LGTM Proposed some wording changes. |
| @@ -13,14 +13,14 @@ Also, don't forget to check out [the documentation](https://aka.ms/dotnet-cli-do | |||
|
|
|||
| Changes in issue triaging | |||
| ------------------------- | |||
| As it was explained in the ["Changes to project.json" blog post](https://blogs.msdn.microsoft.com/dotnet/2016/05/23/changes-to-project-json/), we are making significant changes to the CLI tooling by supporting MSBuild as the build engine and `csproj` as the project format. As we are starting that work, we've realized that this also means that many of the shortcomings of the current tooling will be solved by this move. Given this, we've decided to introduce two new labels for issues to indicate that. These labels are: | |||
| As it was explained in the ["Changes to project.json" blog post](https://blogs.msdn.microsoft.com/dotnet/2016/05/23/changes-to-project-json/), we are making significant changes to the CLI tooling by supporting MSBuild as the build engine and `csproj` as the project format. We've realized that this also means that many of the shortcomings of the current tooling will be solved by this move. Given this, we've decided to introduce two new labels for issues to indicate that. These labels are: | |||
|
|
|||
| * `msbuild-mitigated` label - this label indicates that we belive the issue in question will be mitigated via move to MSBuild. | |||
This comment was marked as spam.
This comment was marked as spam.
Sorry, something went wrong.
|
Should there be a third label, for issues that were triaged and are believed to still be applicable? |
|
@svick the last group is by exclusion, that is, all issues that are left are the ones we believe are still applicable. |
|
@richlander ain't nothing wrong with old books. 😉 |
|
LGTM |
TheRealPiotrP
pushed a commit
that referenced
this pull request
Jul 23, 2016
* Add Test for removing readonly flag when copying readonly library assets * change namespace * PR Feedback * Update README.md (#3904) * Update README.md * Responding to PR feedback * Responding to PR feedback
TheRealPiotrP
pushed a commit
that referenced
this pull request
Jul 26, 2016
* Add Test for removing readonly flag when copying readonly library assets * change namespace * PR Feedback * Fix newlines in the first run experience message The newlines in the first run experience were missing which made the text look a little squashed. Fixes #3909 * Update README.md (#3904) * Update README.md * Responding to PR feedback * Responding to PR feedback
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
skip ci please
/cc @piotrpMSFT @eerhardt @richlander @shanselman