This repository has been archived by the owner on Apr 20, 2023. It is now read-only.
Fixing CLIBUILD_SKIP_TESTS on docker by passing the environment variable through to the docker container. #5274
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ble through to the docker container.
jonsequitur
approved these changes
Jan 11, 2017
|
See #5275 to fix this issue for real. |
livarcocc
approved these changes
Jan 11, 2017
|
Maybe we shouold make these fixes into rc3, so that we can then just merge that branch back into rel. Not a big deal, but this way we need to keep cherry-picking these commits. |
|
This got fixed in RC3 last night... should we just merge RC3 into rel/1.0.0? |
|
Superseded by #5282 |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Tests are still running on our Linux builds on official VSO runs.
@livarcocc @piotrpMSFT @jonsequitur @krwq