Skip to content
This repository has been archived by the owner on Apr 20, 2023. It is now read-only.

Update CoreSetup to beta-001834 (master) #6095

Closed
wants to merge 1 commit into from
Closed

Update CoreSetup to beta-001834 (master) #6095

wants to merge 1 commit into from

Conversation

dotnet-bot
Copy link

@dotnet-bot dotnet-bot commented Mar 22, 2017 •
edited
Loading

/cc @dotnet/dotnet-cli

@dnfclas
Copy link

dnfclas commented Mar 22, 2017

@dotnet-bot,
Thanks for having already signed the Contribution License Agreement. Your agreement was validated by .NET Foundation. We will now review your pull request.
Thanks,
.NET Foundation Pull Request Bot

@livarcocc
Copy link

@dotnet-bot Test this please

@dotnet-bot dotnet-bot changed the title Update CoreSetup to beta-001816 (master) Update CoreSetup to beta-001820 (master) Mar 22, 2017
@livarcocc
Copy link

@gkhanna79 crossgen is failing in this build. Can you take a look? This is blocking us from taking a new core-setup, which has the signing fixes we need to do the CLI insertion into VS.

@gkhanna79
Copy link
Member

I do not see a crossgen failure @livarcocc. I do see the following:

18:04:49 Failed to download package 'runtime.rhel.7-x64.Microsoft.NETCore.App.2.0.0-beta-001820-00' from 'https://dotnetmyget.blob.core.windows.net/artifacts/cli-deps/nuget/v3/flatcontainer/runtime.rhel.7-x64.microsoft.netcore.app/2.0.0-beta-001820-00/runtime.rhel.7-x64.microsoft.netcore.app.2.0.0-beta-001820-00.nupkg'. (TaskId:38)
18:04:49 The read operation failed, see inner exception. (TaskId:38)

@gkhanna79
Copy link
Member

Are you downloading a valid package?

@livarcocc
Copy link

@dotnet-bot Test this please

@livarcocc
Copy link

@gkhanna79 What I see in the logs is below for ubuntu x64, for instance.

This is only happening on this PR. CI is working for other PRs, which makes me believe that it is something in the new version of the shared framework.

/opt/code/.nuget/packages/runtime.ubuntu.14.04-x64.microsoft.netcore.app/2.0.0-beta-001820-00/tools/crossgen -readytorun -in "/opt/code/artifacts/ubuntu.14.04-x64/stage2/sdk/2.0.0-preview1-005625/NuGet.Protocol.Core.v3.dll" -out "/tmp/tmpDRBnWd.tmp"  -platform_assemblies_paths /opt/code/artifacts/ubuntu.14.04-x64/stage2/sdk/2.0.0-preview1-005625/:/opt/code/artifacts/ubuntu.14.04-x64/stage2/sdk/2.0.0-preview1-005625/15.0/Microsoft.Common.CrossTargeting.targets/ImportAfter/:/opt/code/artifacts/ubuntu.14.04-x64/stage2/sdk/2.0.0-preview1-005625/15.0/:/opt/code/artifacts/ubuntu.14.04-x64/stage2/sdk/2.0.0-preview1-005625/15.0/Microsoft.Common.targets/ImportAfter/:/opt/code/artifacts/ubuntu.14.04-x64/stage2/sdk/2.0.0-preview1-005625/15.0/SolutionFile/ImportAfter/:/opt/code/artifacts/ubuntu.14.04-x64/stage2/sdk/2.0.0-preview1-005625/cs/:/opt/code/artifacts/ubuntu.14.04-x64/stage2/sdk/2.0.0-preview1-005625/de/:/opt/code/artifacts/ubuntu.14.04-x64/stage2/sdk/2.0.0-preview1-005625/es/:/opt/code/artifacts/ubuntu.14.04-x64/stage2/sdk/2.0.0-preview1-005625/Extensions/:/opt/code/artifacts/ubuntu.14.04-x64/stage2/sdk/2.0.0-preview1-005625/fr/:/opt/code/artifacts/ubuntu.14.04-x64/stage2/sdk/2.0.0-preview1-005625/it/:/opt/code/artifacts/ubuntu.14.04-x64/stage2/sdk/2.0.0-preview1-005625/ja/:/opt/code/artifacts/ubuntu.14.04-x64/stage2/sdk/2.0.0-preview1-005625/ko/:/opt/code/artifacts/ubuntu.14.04-x64/stage2/sdk/2.0.0-preview1-005625/pl/:/opt/code/artifacts/ubuntu.14.04-x64/stage2/sdk/2.0.0-preview1-005625/pt-BR/:/opt/code/artifacts/ubuntu.14.04-x64/stage2/sdk/2.0.0-preview1-005625/Roslyn/:/opt/code/artifacts/ubuntu.14.04-x64/stage2/sdk/2.0.0-preview1-005625/Roslyn/runtimes/any/native/:/opt/code/artifacts/ubuntu.14.04-x64/stage2/sdk/2.0.0-preview1-005625/Roslyn/runtimes/unix/lib/netstandard1.3/:/opt/code/artifacts/ubuntu.14.04-x64/stage2/sdk/2.0.0-preview1-005625/Roslyn/runtimes/win/lib/netstandard1.3/:/opt/code/artifacts/ubuntu.14.04-x64/stage2/sdk/2.0.0-preview1-005625/ru/:/opt/code/artifacts/ubuntu.14.04-x64/stage2/sdk/2.0.0-preview1-005625/runtimes/unix/lib/netstandard1.3/:/opt/code/artifacts/ubuntu.14.04-x64/stage2/sdk/2.0.0-preview1-005625/runtimes/win/lib/netstandard1.3/:/opt/code/artifacts/ubuntu.14.04-x64/stage2/sdk/2.0.0-preview1-005625/tr/:/opt/code/artifacts/ubuntu.14.04-x64/stage2/sdk/2.0.0-preview1-005625/zh-Hans/:/opt/code/artifacts/ubuntu.14.04-x64/stage2/sdk/2.0.0-preview1-005625/zh-Hant/:/opt/code/artifacts/ubuntu.14.04-x64/stage2/shared/Microsoft.NETCore.App/2.0.0-beta-001820-00 -JITPath /opt/code/.nuget/packages/runtime.ubuntu.14.04-x64.microsoft.netcore.app/2.0.0-beta-001820-00/runtimes/ubuntu.14.04-x64/native/libclrjit.so  (TaskId:88)
21:09:15 
�[39;49m�[36m04:09:15.265     1>�[39;49m�[39;49m�[31m/opt/code/src/redist/redist.csproj(178,5): error MSB6006: "crossgen" exited with code 139. [/opt/code/build.proj]

@gkhanna79
Copy link
Member

@rahku can you PTAL?

@dotnet-bot dotnet-bot changed the title Update CoreSetup to beta-001820 (master) Update CoreSetup to beta-001826 (master) Mar 22, 2017
@rahku
Copy link

rahku commented Mar 22, 2017

looking

@rahku
Copy link

rahku commented Mar 22, 2017

crossgen is crashing at this callstack
(lldb) bt

  • thread #1: tid = 20599, 0x000000000055cab8 crossgen`Precode::GetMethodDesc(int) [inlined] Precode::GetType(this=0x0000000000000000) at precode.h:128, name = 'crossgen', stop reason = invalid address (fault address: 0x0)
    • frame #0: 0x000000000055cab8 crossgenPrecode::GetMethodDesc(int) [inlined] Precode::GetType(this=0x0000000000000000) at precode.h:128 frame #1: 0x000000000055cab8 crossgenPrecode::GetMethodDesc(this=0x0000000000000000, fSpeculative=0) + 8 at precode.cpp:127
      frame #2: 0x000000000053f515 crossgenMethodDesc::GetMethodDescFromStubAddr(unsigned long, int) [inlined] Precode::GetPrecodeFromEntryPoint(fSpeculative=0) + 40 at precode.h:290 frame #3: 0x000000000053f4ed crossgenMethodDesc::GetMethodDescFromStubAddr(addr=0, fSpeculative=0) + 13 at method.cpp:4386
      frame #4: 0x0000000000542523 crossgenMethodTable::GetMethodDescForInterfaceMethod(TypeHandle, MethodDesc*) [inlined] MethodTable::GetMethodDescForSlotAddress(addr=0, fSpeculative=BOOL at scalar) + 44 at methodtable.cpp:7544 frame #5: 0x00000000005424f7 crossgenMethodTable::GetMethodDescForInterfaceMethod(this=, ownerType=, pInterfaceMD=) + 103 at methodtable.cpp:2136
      frame dotnet-commands Command #6: 0x00000000005307c8 crossgenCEEInfo::resolveVirtualMethod(CORINFO_METHOD_STRUCT_*, CORINFO_CLASS_STRUCT_*, CORINFO_METHOD_STRUCT_*) + 325 at jitinterface.cpp:8763 frame #7: 0x0000000000530683 crossgenCEEInfo::resolveVirtualMethod(this=, methodHnd=, derivedClass=, ownerType=0x00007fffefdb4fc9) + 339 at jitinterface.cpp:8839
      frame Spike of dotnet-compile/publish/run #8: 0x00007ffff579e436 libclrjit.soCompiler::impDevirtualizeCall(this=0x00007fffefd60020, call=0x00007fffefd6b894, thisObj=<unavailable>, callInfo=0x00007fffffffb320, exactContextHandle=0x00007fffffffad88) + 278 at importer.cpp:18468 frame #9: 0x00007ffff579c946 libclrjit.soCompiler::impImportCall(this=0x00007fffefd60020, opcode=CEE_CALLVIRT, pResolvedToken=0x00007fffffffb220, pConstrainedResolvedToken=0x0000000000000000, newobjThis=0x0000000000000000, prefixFlags=0, callInfo=0x00007ffff7ee1908, rawILOffset=) + 3062 at importer.cpp:7332
      frame #10: 0x00007ffff57b3dab libclrjit.soCompiler::impImportBlockCode(this=0x00007fffefd60020, block=0x00007fffefd64f5c) + 79707 at importer.cpp:12822 frame #11: 0x00007ffff57b64b1 libclrjit.soCompiler::impImportBlock(BasicBlock*) + 35 at importer.cpp:15629
      frame #12: 0x00007ffff57b648e libclrjit.soCompiler::impImportBlock(this=0x00007fffefd60020, block=0x00007fffefd64f5c) + 334 at importer.cpp:15639 frame #13: 0x00007ffff57b9af8 libclrjit.soCompiler::impImport(this=0x00007fffefd60020, method=) + 2984 at importer.cpp:16713
      frame #14: 0x00007ffff575a22c libclrjit.soCompiler::fgImport(this=0x00007fffefd60020) + 28 at flowgraph.cpp:6700 frame #15: 0x00007ffff573e8de libclrjit.soCompiler::compCompile(this=0x00007fffefd60020, methodCodePtr=0x00007fffffffbaf0, methodCodeSize=0x00007fffffffbb44, compileFlags=0x00007fffffffbb00) + 318 at compiler.cpp:4206
      frame #16: 0x00007ffff5740e8a libclrjit.soCompiler::compCompileHelper(this=0x00007fffefd60020, classPtr=<unavailable>, compHnd=<unavailable>, methodInfo=<unavailable>, methodCodePtr=0x00007fffffffbaf0, methodCodeSize=0x00007fffffffbb44, compileFlags=<unavailable>, instVerInfo=-177014896) + 906 at compiler.cpp:5799 frame #17: 0x00007ffff5740787 libclrjit.soCompiler::compCompile(CORINFO_METHOD_STRUCT_, CORINFO_MODULE_STRUCT_, ICorJitInfo*, CORINFO_METHOD_INFO*, void**, unsigned int*, JitFlags*) [inlined] Compiler::compCompile(CORINFO_METHOD_STRUCT_, CORINFO_MODULE_STRUCT_, ICorJitInfo*, CORINFO_METHOD_INFO*, void**, unsigned int*, JitFlags*)::$1::operator()(Compiler::compCompile(CORINFO_METHOD_STRUCT, CORINFO_MODULE_STRUCT_, ICorJitInfo*, CORINFO_METHOD_INFO*, void**, unsigned int*, JitFlags*)::JITParam*) const + 29 at compiler.cpp:5151
      frame #18: 0x00007ffff574076a libclrjit.soCompiler::compCompile(this=0x00007fffefd60020, methodHnd=0x00007ffff4665bf0, classPtr=0x00007ffff7f8bc38, compHnd=0x00007fffffffc128, methodInfo=0x00007fffffffc160, methodCodePtr=0x00007fffffffbaf0, methodCodeSize=0x00007fffffffbb44, compileFlags=<unavailable>) + 778 at compiler.cpp:5171 frame #19: 0x00007ffff5741824 libclrjit.sojitNativeCode(CORINFO_METHOD_STRUCT      *, CORINFO_MODULE_STRUCT      , ICorJitInfo, CORINFO_METHOD_INFO*, void**, unsigned int*, JitFlags*, void*) + 217 at compiler.cpp:6450
      frame #20: 0x00007ffff574174b libclrjit.sojitNativeCode(CORINFO_METHOD_STRUCT_*, CORINFO_MODULE_STRUCT_*, ICorJitInfo*, CORINFO_METHOD_INFO*, void**, unsigned int*, JitFlags*, void*) at compiler.cpp:6474 frame #21: 0x00007ffff574174b libclrjit.sojitNativeCode(methodHnd=0x00007ffff4665bf0, classPtr=0x00007ffff7f8bc38, compHnd=0x00007fffffffc128, methodInfo=0x00007fffffffc160, methodCodePtr=0x00007fffffffbaf0, methodCodeSize=0x00007fffffffbb44, compileFlags=0x00007fffffffbb00, inlineInfoPtr=0x0000000000000000) + 555 at compiler.cpp:6476
      frame #22: 0x00007ffff574519b libclrjit.soCILJit::compileMethod(this=<unavailable>, compHnd=0x00007fffffffc128, methodInfo=0x00007fffffffc160, flags=<unavailable>, entryAddress=0x00007fffffffbb48, nativeSizeOfCode=0x00007fffffffbb44) + 171 at ee_il_dll.cpp:296 frame #23: 0x000000000069d8ae crossgenZapInfo::CompileMethod(this=) + 622 at zapinfo.cpp:504
      frame #24: 0x0000000000696ec9 crossgenZapImage::TryCompileMethodWorker(this=<unavailable>, handle=<unavailable>, md=<unavailable>, methodProfilingDataFlags=<unavailable>) + 457 at zapimage.cpp:2068 frame #25: 0x0000000000695e04 crossgenZapImage::TryCompileMethodDef(this=0x0000000000ae4900, md=100663525, methodProfilingDataFlags=0) + 420 at zapimage.cpp:1927
      frame #26: 0x000000000069661a crossgenZapImage::Compile(this=0x0000000000ae4900) + 186 at zapimage.cpp:1697 frame #27: 0x0000000000690605 crossgenZapper::CompileModule(this=0x0000000000a71310, hModule=, pAssemblyEmit=) + 197 at zapper.cpp:1658
      frame #28: 0x000000000068f7d9 crossgenZapper::CompileAssembly(this=0x0000000000a71310, pNativeImageSig=0x0000000000000000) + 745 at zapper.cpp:1554 frame #29: 0x000000000068c832 crossgenZapper::Compile(char16_t const*, _GUID*) [inlined] Zapper::CompileInCurrentDomain(this=, string=, pNativeImageSig=) + 402 at zapper.cpp:1296
      frame #30: 0x000000000068c827 crossgenZapper::Compile(char16_t const*, _GUID*) [inlined] Zapper::Compile(char16_t const*, _GUID*)::Callback::doCallback() at zapper.cpp:1201 frame #31: 0x000000000068c827 crossgenZapper::Compile(char16_t const*, _GUID*) [inlined] Zapper::InvokeDomainCallback(Zapper::DomainCallback*) at zapper.cpp:947
      frame #32: 0x000000000068c827 crossgenZapper::Compile(this=0x0000000000a71310, string=<unavailable>, pNativeImageSig=<unavailable>) + 391 at zapper.cpp:1233 frame #33: 0x000000000068c478 crossgenNGenWorker(pwzFilename=0x0000000000a66f20, dwFlags=, pwzPlatformAssembliesPaths=, pwzTrustedPlatformAssemblies=, pwzPlatformResourceRoots=, pwzAppPaths=0x0000000000000000, pwzOutputFilename=, pwzPlatformWinmdPaths=, pLogger=, pwszCLRJITPath=) + 472 at zapper.cpp:177
      frame #34: 0x00000000004f52b9 crossgenwmain(argc=<unavailable>, argv=<unavailable>) + 3801 at crossgen.cpp:933 frame #35: 0x00000000004f56d3 crossgenmain(argc=10, argv=) + 211 at crossgen.cpp:982
      frame #36: 0x00007ffff65adf45 libc.so.6__libc_start_main + 245 frame #37: 0x00000000004f3277 crossgen_start + 41

@rahku
Copy link

rahku commented Mar 22, 2017

@AndyAyersMS looks like you have recently been making changes in this area. Is this issue fixed in master? Can you take a look

@AndyAyersMS
Copy link
Member

I believe the just-merged dotnet/coreclr#10371 should fix this; let me see if I can verify that somehow.

@AndyAyersMS
Copy link
Member

Verified. I can repro the crossgen failure in NuGet.Protocol.Core.v3.dll on older builds; it is fixed with dotnet/coreclr#10371.

@dotnet-bot dotnet-bot changed the title Update CoreSetup to beta-001826 (master) Update CoreSetup to beta-001828 (master) Mar 23, 2017
@dotnet-bot dotnet-bot changed the title Update CoreSetup to beta-001828 (master) Update CoreSetup to beta-001834 (master) Mar 23, 2017
@ellismg
Copy link

ellismg commented Mar 24, 2017

Closing in favor of #6135

@ellismg ellismg closed this Mar 24, 2017
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@livarcocc livarcocc livarcocc approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
7 participants
@dotnet-bot @dnfclas @livarcocc @gkhanna79 @rahku @AndyAyersMS @ellismg