ASP .Net Core Runtime inclusion in the CLI

[johnbeisner]

ASP .Net Core Runtime inclusion in the CLI

Enabling the download of ASP .Net Core Runtime blob storage: wixlibs and zip file to include with the CLI
ZIP file archive inclusion; wixlib still todo...

https://github.com/dotnet/cli/issues/6371
@dotnet/dotnet-cli

[omajid]

cc'ing @ellismg since this might impact the source-build stuff

[livarcocc]

@ramarag @eerhardt can you guys help us understand the changes we need to make to get these tests passing again? I imagine they are failing because now we have the runtime store next to the SDK and dlls that were not supposed to be found are being found.

[eerhardt]

cli/test/dotnet-store.Tests/GivenDotnetStoresAndPublishesProjects.cs

Lines 71 to 106 in 0f51901

	public void AppFailsDueToMissingCache()
	{
	var testAppName = "NewtonSoftDependentProject";
	var profileProjectName = "NewtonsoftProfile";
	var targetManifestFileName = "NewtonsoftFilterProfile.xml";
	var testInstance = TestAssets.Get(testAppName)
	.CreateInstance()
	.WithSourceFiles()
	.UseCurrentRuntimeFrameworkVersion();
	var testProjectDirectory = testInstance.Root.ToString();
	var profileProjectPath = TestAssets.Get(profileProjectName).Root.FullName;
	var profileFilter = Path.Combine(profileProjectPath, targetManifestFileName);
	new RestoreCommand()
	.WithWorkingDirectory(testProjectDirectory)
	.Execute()
	.Should().Pass();
	var configuration = Environment.GetEnvironmentVariable("CONFIGURATION") ?? "Debug";
	new PublishCommand()
	.WithFramework(_tfm)
	.WithWorkingDirectory(testProjectDirectory)
	.WithTargetManifest(profileFilter)
	.Execute()
	.Should().Pass();
	var outputDll = Path.Combine(testProjectDirectory, "bin", configuration, _tfm, "publish", $"{testAppName}.dll");
	new DotnetCommand()
	.ExecuteWithCapturedOutput(outputDll)
	.Should().Fail()
	.And.HaveStdErrContaining($"Error: assembly specified in the dependencies manifest was not found probably due to missing runtime store associated with {targetManifestFileName} -- package: 'Newtonsoft.Json',");
	}

The test tries to make a project that is dependent on Newtonsoft, and does a publish with excluding the Newtonsoft library. The idea being Newtonsoft should be available in a runtime store.

And then the test is testing what happens when Newtonsoft isn't in a runtime store - you should get a nice error message.

If ASP.NET is putting Newtonsoft in their store, the test is probably picking it up, and failing to fail correctly.

To fix this, one idea is to use a different assembly. Maybe a NuGet.Common.dll or something that isn't in the ASP.NET runtime store.

[livarcocc]

@ManishJayaswal @Pilchie for approval.

[ManishJayaswal]

@johnbeisner - sorry folks but I need to understand the customer scenario before approving. Just a few lines about what would happen if we do not take this fix and workaround if any.

[livarcocc]

@dotnet-bot Test OpenSUSE42.1 x64 Debug Build
@dotnet-bot Test Ubuntu x64 Release Build
@dotnet-bot Test Ubuntu16.04 x64 Debug Build

[livarcocc]

@ManishJayaswal This is not a bug fix. This is a feature. This is adding the ASP.NET Runtime Store to the CLI, so that the CLI carries it. This feature has been cooking for a while from the runtime all the way up to asp.net. Now they are producing the runtime store and we are consuming it.

[tmds]

@livarcocc @johnbeisner @ManishJayaswal I'd like to understand this a bit better.
What is the "ASP.NET Runtime Store" (-> what is in the wixlibs and zip file)?
Are these files included in the CLI installer? Or are they downloaded on first use?
Is this optional? Or does every CLI build need to include it?