Implement `dotnet publish --no-build` #8996

nguerrera · 2018-04-04T22:04:24Z

Fix #5331

test/dotnet-publish.Tests/GivenDotnetPublishPublishesProjects.cs

+            new NewCommandShim()
+                .WithWorkingDirectory(rootPath)
+                .Execute(newArgs)
+                .Should().Pass();


test/dotnet-msbuild.Tests/GivenDotnetPublishInvocation.cs

@@ -72,6 +72,23 @@ public void MsbuildInvocationIsCorrectForSeparateRestore(string[] args, string e
                   .Be($"{ExpectedPrefix} -nologo -target:Publish{expectedAdditionalArgs}");
        }



src/dotnet/commands/dotnet-publish/LocalizableStrings.resx

@@ -141,4 +141,7 @@
  <data name="SelfContainedOptionDescription" xml:space="preserve">
    <value>Publish the .NET Core runtime with your application so the runtime doesn't need to be installed on the target machine. Defaults to 'true' if a runtime identifier is specified.</value>
  </data>
+  <data name="NoBuildOptionDescription" xml:space="preserve">
+    <value>Do not build project before publishing.  Implies --no-restore.</value>


nguerrera · 2018-04-06T01:11:45Z

Daniel reviewed the last two commits over my shoulder. This is good to merge when green. I will do so from home if nobody beats me to it.

Implement dotnet publish --no-build

b6174af

nguerrera requested review from livarcocc and a team April 4, 2018 22:04

dsplaisted approved these changes Apr 4, 2018

View reviewed changes

livarcocc reviewed Apr 5, 2018

View reviewed changes

livarcocc approved these changes Apr 5, 2018

View reviewed changes

livarcocc added this to the 2.1.3xx milestone Apr 5, 2018

nguerrera added 2 commits April 5, 2018 16:07

Tweak --no-build messages based on PR feedback

42e0aff

Add test cases per PR feedback

60e7985

nguerrera merged commit 4956bfe into dotnet:master Apr 6, 2018

nguerrera deleted the publish-no-build branch September 26, 2018 20:29

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Implement `dotnet publish --no-build` #8996

Implement `dotnet publish --no-build` #8996

nguerrera commented Apr 4, 2018

This comment was marked as spam.

This comment was marked as spam.

This comment was marked as spam.

This comment was marked as spam.

This comment was marked as spam.

This comment was marked as spam.

This comment was marked as spam.

This comment was marked as spam.

This comment was marked as spam.

This comment was marked as spam.

This comment was marked as spam.

This comment was marked as spam.

This comment was marked as spam.

This comment was marked as spam.

nguerrera commented Apr 6, 2018

		@@ -72,6 +72,23 @@ public void MsbuildInvocationIsCorrectForSeparateRestore(string[] args, string e
		.Be($"{ExpectedPrefix} -nologo -target:Publish{expectedAdditionalArgs}");
		}

Implement dotnet publish --no-build #8996

Implement dotnet publish --no-build #8996

Conversation

nguerrera commented Apr 4, 2018

This comment was marked as spam.

This comment was marked as spam.

This comment was marked as spam.

This comment was marked as spam.

This comment was marked as spam.

This comment was marked as spam.

This comment was marked as spam.

This comment was marked as spam.

This comment was marked as spam.

This comment was marked as spam.

This comment was marked as spam.

This comment was marked as spam.

This comment was marked as spam.

This comment was marked as spam.

nguerrera commented Apr 6, 2018

Implement `dotnet publish --no-build` #8996

Implement `dotnet publish --no-build` #8996