Skip to content
This repository has been archived by the owner on Jul 12, 2022. It is now read-only.

Add rule to remove unused usings. #101

Closed
wants to merge 1 commit into from
Closed

Add rule to remove unused usings. #101

wants to merge 1 commit into from

Conversation

amanda-mitchell
Copy link

This pull request adds a rule to remove unused using directives from the beginning of source files. It addresses issue #79.

@dnfclas
Copy link

dnfclas commented Mar 26, 2015

Hi @david-mitchell, I'm your friendly neighborhood .NET Foundation Pull Request Bot (You can call me DNFBOT). Thanks for your contribution!

In order for us to evaluate and accept your PR, we ask that you sign a contribution license agreement. It's all electronic and will take just minutes. I promise there's no faxing. https://cla2.dotnetfoundation.org.

TTYL, DNFBOT;

@dnfclas
Copy link

dnfclas commented Mar 26, 2015

@david-mitchell, Thanks for signing the contribution license agreement so quickly! Actual humans will now validate the agreement and then evaluate the PR.

Thanks, DNFBOT;

@Priya91
Copy link
Contributor

Priya91 commented Jun 19, 2015

👍 LGTM

@Priya91 Priya91 changed the title Add rule to remove unused usings. #79 Add rule to remove unused usings. Jun 19, 2015
@amanda-mitchell
Copy link
Author

Updated.

@jaredpar
Copy link
Member

jaredpar commented Jul 8, 2015

@dotnet-bot test this please

@NickCraver
Copy link
Member

I'd like to see this for a project as well - but I can't see what tests were failing at this point, looks like the builds age out. @jaredpar can you poke the bot again pretty please?

@jaredpar
Copy link
Member

jaredpar commented Nov 8, 2015

@dotnet-bot test this please

@jaredpar
Copy link
Member

jaredpar commented Nov 8, 2015

Looks like a real build error

error CS0616: 'LocalSemanticRuleOrder' is not an attribute class 

@amanda-mitchell
Copy link
Author

I finally got around to updating this.

@michaelcfanning
Copy link

I believe the anfix branch also includes this analysis (one that wraps the internal 'unused namespace directive' analysis. when will we converge, I wonder? :)
@lgolding @srivatsn @jaredpar @Priya91

@amanda-mitchell
Copy link
Author

Is there anything I can do to speed up the process of getting this accepted?

The first time I submitted it, so much time went by between submission and review that the underlying API changed, breaking the submission.

@amanda-mitchell
Copy link
Author

@jaredpar, any chance of getting this merged someday? It's been open for nearly a year and a half.

@twenzel
Copy link

twenzel commented Feb 21, 2018

Any updates? Is this repository stale?

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

8 participants