Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Include .NET Core Runtime in WindowsDesktop bundle #3798

Closed
dagood opened this issue Oct 8, 2019 · 2 comments
Closed

Include .NET Core Runtime in WindowsDesktop bundle #3798

dagood opened this issue Oct 8, 2019 · 2 comments
Assignees
Milestone

Comments

@dagood
Copy link
Member

dagood commented Oct 8, 2019

To run a .NET Core WPF/WinForms app, you need to install both the .NET Core Runtime and WindowsDesktop Runtime. (As well as the correct x86/x64 bitness.) This is unexpected and is a significant pain point when trying to deploy FDE WinForms and WPF apps.

This issue tracks the incremental step of including the .NET Core Runtime dependency in the installer bundle for the WindowsDesktop Runtime.

This will bring our current matrix of 4 installers needed to run WindowsDesktop apps:

x64 x86
.NET Core Runtime x x
.NET Desktop Runtime x x

down to 2:

x64 x86
.NET Desktop Runtime x x

Then, later, we may be able to combine the x86/x64 ones as well by completing https://github.com/dotnet/core-setup/issues/7763. (This is more difficult from an implementation perspective.)

/cc @KathleenDollard @leecow @dleeapho @MichaelSimons @rowanmiller

@KathleenDollard
Copy link
Contributor

👍 Yeah!

@dagood dagood self-assigned this Oct 8, 2019
@dagood
Copy link
Member Author

dagood commented Oct 15, 2019

This is merged for 3.1 preview 2 with PR dotnet/core-setup#8508!

Waiting to gather data/feedback before potentially porting to the 3.0 servicing branch as well. (Not tracking that in this issue.)

Implementing it in 5.0+ has to be done separately in the dotnet/windowsdesktop repo, dotnet/windowsdesktop#20 tracks that.

@dagood dagood closed this as completed Oct 15, 2019
@msftgits msftgits transferred this issue from dotnet/core-setup Jan 30, 2020
@msftgits msftgits added this to the 3.1 milestone Jan 30, 2020
@ghost ghost locked as resolved and limited conversation to collaborators Dec 12, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

No branches or pull requests

3 participants