This repository has been archived by the owner on Jan 23, 2023. It is now read-only.
Add support for the "path" property in the .deps.json file #235
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| @@ -18,8 +18,32 @@ public class RuntimeLibrary : Library | |||
| IReadOnlyList<RuntimeAssetGroup> nativeLibraryGroups, | |||
| IEnumerable<ResourceAssembly> resourceAssemblies, | |||
| IEnumerable<Dependency> dependencies, | |||
| bool serviceable) | |||
| : base(type, name, version, hash, dependencies, serviceable) | |||
| bool serviceable) : this( | |||
This comment was marked as spam.
This comment was marked as spam.
Sorry, something went wrong.
This comment was marked as spam.
This comment was marked as spam.
Sorry, something went wrong.
|
|
Looks great. Thanks for doing this.
|
@joelverhagen Are you also going to update the host to support using this "path", like you did in your earlier approach (in PR https://github.com/dotnet/core-setup/pull/64/files)? CC @schellap |
|
@gkhanna79, yes. That's the next step. |
joelverhagen
force-pushed
the
jver/depspath
branch
2 times, most recently
from
7252718
to
19837b4
Compare
| @@ -10,6 +10,11 @@ namespace Microsoft.Extensions.DependencyModel | |||
| public class Library | |||
| { | |||
| public Library(string type, string name, string version, string hash, IEnumerable<Dependency> dependencies, bool serviceable) | |||
This comment was marked as spam.
This comment was marked as spam.
Sorry, something went wrong.
This comment was marked as spam.
This comment was marked as spam.
Sorry, something went wrong.
|
Couple of small things but LGTM. |
joelverhagen
force-pushed
the
jver/depspath
branch
from
19837b4
to
57da9d5
Compare
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
@eerhardt mentioned that Microsoft.Extensions.DependencyModel project moved to core-setup repository in my cli PR dotnet/cli#4032. This PR is porting the relevant changes from that cli to core-setup.
The purpose of this PR is to support the
"path"property in the.deps.jsonfile. Eventually the DotNetHost will prefer this "path" proper over the concatenation of ID and version when looking for a package in the global packages folder.This is part of step #3 in this NuGet issue: NuGet/Home#2522.
/cc @eerhardt @livarcocc @gkhanna79 @piotrpMSFT @schellap