This repository has been archived by the owner on Jan 23, 2023. It is now read-only.
Read the path and hashPath properties when reading .deps.json in hostfxr/policy #247
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| { | ||
| library_path = library_path_iter->second.as_string(); | ||
|
|
||
| if (_X('/') != DIR_SEPARATOR) |
This comment was marked as spam.
This comment was marked as spam.
Sorry, something went wrong.
This comment was marked as spam.
This comment was marked as spam.
Sorry, something went wrong.
| append_path(&hash_file, library_name.c_str()); | ||
| append_path(&hash_file, library_version.c_str()); | ||
| append_path(&hash_file, nupkg_filename.c_str()); | ||
| if (library_path.empty()) |
This comment was marked as spam.
This comment was marked as spam.
Sorry, something went wrong.
This comment was marked as spam.
This comment was marked as spam.
Sorry, something went wrong.
This comment was marked as spam.
This comment was marked as spam.
Sorry, something went wrong.
|
LGTM |
|
Please validate the scenarios (with and w/o the data) and confirm they work :) |
|
|
joelverhagen
added a commit
that referenced
this pull request
Sep 21, 2016
Read the path and hashPath properties when reading .deps.json in hostfxr/policy (cherry picked from commit e5d4769)
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Since a "hashPath" and "path" property are now in the .deps.json file, this PR updates the native components in core-setup to prefer these values over manually constructing the paths.
Addresses the next point in NuGet/Home#2522.
This is a reincarnation of #64.
/cc @gkhanna79 @schellap @eerhardt @livarcocc @piotrpMSFT