This repository has been archived by the owner on Jan 23, 2023. It is now read-only.
Make Microsoft.NETCore.App target netcoreapp2.1 #3052
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
It appears that the host tests are running on the tool runtime shared framework rather than the latest, this is why they weren't previously setting https://github.com/dotnet/core-setup/pull/3052/files#diff-f0d086118617516dc27f578d0d67a348R4 |
Moves the branch forward to the netcoreapp2.1 TFM.
It looks like Store wasn't doing the right thing for test projects. Rather than storing the just built NCA package it was using the one the targets injected (EG: the one in the Tools CLI).
|
@weshaggard can you review this ASAP? It will be needed to unblock ingestion of corefx now that I've moved it to 2.1. |
weshaggard
approved these changes
Aug 15, 2017
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Moves the branch forward to the netcoreapp2.1 TFM.
Fixes #3030
/cc @weshaggard