-
Notifications
You must be signed in to change notification settings - Fork 219
Conversation
- Delete the unversioned directories, CI and VSO has been updated to use the new names. - Remove adding llvm.org/apt/ to the sources list. The LLVM team suspended this 05/31/2016 so building containers from scratch with these Dockerfiles was failing. It turns out that lldb-3.6 (which is what we were using the source for) is now in Ubuntu 14.04 (trusty) so we didn't need it anymore. LLDB is only required there because CoreCLR has a dependency on it for some debugging stuff, and we need it on the box so the depends sniffing when doing the deb package builds gets confused if the imports are un-resolved. When we go to add packages for debian.8, we'll need to come up with a stragegy to get this package or turn off the auto-sniffing. - I also shrunk down the list of packages to install based on a humna's understanding of the dependencies of CoreCLR and CoreFX instead of what a complication ldd invocation piped across dpkg searching told us. This is much more readable and a better indication of the CLR dependencies, IMHO
Hi @ellismg, I'm your friendly neighborhood .NET Foundation Pull Request Bot (You can call me DNFBOT). Thanks for your contribution! The agreement was validated by .NET Foundation and real humans are currently evaluating your PR. TTYL, DNFBOT; |
@brthor @MichaelSimons My docker-fu is pretty weak, so maybe you want to take a look. I'm specifically interested in if the apt-get clean && rm -rf /var/apt/lists/* is a best practice or not in each layer (the guidance I found was mixed). I found that with and without it I was getting periodic hash mismatch errors, doing the cache busting in each layer seemed safer, but again I'm not an expert. This should address the invalid GPG key errors we were seeing (I expect the will happen more and more often as CI machines are recycled and the prebuilt images are no longer in caches). |
Should CI be triggered on this branch now? Should I push this into master first instead? |
zlib1g \ | ||
libuuid1 && \ | ||
apt-get clean && \ | ||
rm -rf /var/lib/apt/lists/* | ||
|
||
# Install Build Prereqs |
This comment was marked as spam.
This comment was marked as spam.
Sorry, something went wrong.
This comment was marked as spam.
This comment was marked as spam.
Sorry, something went wrong.
This comment was marked as spam.
This comment was marked as spam.
Sorry, something went wrong.
I'm not sure why CI isn't running here. I will look into this, this morning. |
After this goes in We should have CI for this. |
Hi @ellismg, I'm your friendly neighborhood .NET Foundation Pull Request Bot (You can call me DNFBOT). Thanks for your contribution! The agreement was validated by .NET Foundation and real humans are currently evaluating your PR. TTYL, DNFBOT; |
@mmitche Any ideas why the permissions on this directory might be messed up in CI?
This is on dci-macpro-02 |
@ellismg Ahh cool thanks for the heads up. It was created as root |
@dotnet-bot test OSX x64 Release Build please |
Is this mergable? So we can unblock Jenkins? |
I'll merge this now to unblock CI and address feedback in a follow up later today/tonight. |
use the new names.
suspended this 05/31/2016 so building containers from scratch with
these Dockerfiles was failing. It turns out that lldb-3.6 (which is
what we were using the source for) is now in Ubuntu 14.04 (trusty) so
we didn't need it anymore. LLDB is only required there because
CoreCLR has a dependency on it for some debugging stuff, and we need
it on the box so the depends sniffing when doing the deb package
builds gets confused if the imports are un-resolved. When we go to
add packages for debian.8, we'll need to come up with a stragegy to
get this package or turn off the auto-sniffing.
understanding of the dependencies of CoreCLR and CoreFX instead of
what a complication ldd invocation piped across dpkg searching told
us. This is much more readable and a better indication of the CLR
dependencies, IMHO