Skip to content
This repository has been archived by the owner on Jan 23, 2023. It is now read-only.

Pass env into ExecCore #92

Merged
merged 1 commit into from
Jun 6, 2016
Merged

Pass env into ExecCore #92

merged 1 commit into from
Jun 6, 2016

Conversation

schellap
Copy link

@schellap schellap commented Jun 6, 2016

Looks like a copy paste error

Looks like a copy paste error
@schellap
Copy link
Author

schellap commented Jun 6, 2016

@brthor or @eerhardt PTAL

Cc @JohnChen0 @gkhanna79

@joshfree
Copy link
Member

joshfree commented Jun 6, 2016

Thanks for fixing https://github.com/dotnet/core-setup/issues/84

@eerhardt
Copy link
Member

eerhardt commented Jun 6, 2016

:shipit:

@eerhardt eerhardt merged commit 1206307 into release/1.0.0 Jun 6, 2016
@eerhardt eerhardt deleted the exec-core branch June 6, 2016 14:10
@gkhanna79 gkhanna79 assigned schellap and unassigned JohnChen0 Jun 6, 2016
@gkhanna79
Copy link
Member

@eerhardt Does CLI need this fix as well? Also, @schellap Are you going to fix this in core-setup master as well?

@eerhardt
Copy link
Member

eerhardt commented Jun 6, 2016

@eerhardt Does CLI need this fix as well?

Good call. I opened dotnet/cli#3397.

@schellap Are you going to fix this in core-setup master as well?

We will have a "mop up" RI from release/1.0.0 into master, so you don't need to manually do dual checkins.

@brthor
Copy link

brthor commented Jun 6, 2016

Thanks @schellap That has likely been there a long time as I don't recall anyone touching that file in some time.

👍

@gkhanna79
Copy link
Member

We will have a "mop up" RI from release/1.0.0 into master, so you don't need to manually do dual checkins.

Thanks.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
7 participants