Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

.NET 7.0 RC 2 #7865

Closed
dcwhittaker opened this issue Oct 11, 2022 · 11 comments
Closed

.NET 7.0 RC 2 #7865

dcwhittaker opened this issue Oct 11, 2022 · 11 comments

Comments

@dcwhittaker
Copy link
Member

dcwhittaker commented Oct 11, 2022

Release Notes

Please report any issues you find with .NET 7 RC2, either responding to this issue, creating a new issue or creating a new issue in one of the following repos:

Known Issues

If there are any issues with this release we will track them here and check issues off as they're resolved. See the linked issues for details on progress and resolution details.

@dcwhittaker dcwhittaker pinned this issue Oct 11, 2022
@gdar91
Copy link

gdar91 commented Oct 11, 2022

F# / C# interop fails when upgrading to the RC2.
To reproduce, create a solution with two – F# Library and C# Console projects. Reference the F# project from the C# one. Add at least two types in the Library.fs file (two single case discriminated unions for simplicity…) and access THE FIRST ONE from the C# project. It will throw: ” Program.cs(1, 24): [CS0117] ‘Test.A’ does not contain a definition for ‘A'”

@gdar91
Copy link

gdar91 commented Oct 11, 2022

F# / C# interop fails when upgrading to the RC2. To reproduce, create a solution with two – F# Library and C# Console projects. Reference the F# project from the C# one. Add at least two types in the Library.fs file (two single case discriminated unions for simplicity…) and access THE FIRST ONE from the C# project. It will throw: ” Program.cs(1, 24): [CS0117] ‘Test.A’ does not contain a definition for ‘A'”

https://github.com/gdar91/Rc2FsCs

@gortok
Copy link

gortok commented Oct 16, 2022

For .NET 7 RC 2 release you mention CVE-2022-38013, but for .NET 6 and .NET Core 3.1 release (3.1.30 and 6.0.10), you keep the exact same release text but reference an newer CVE, CVE-2022-41032.

Should the .NET 7 RC2 release notes also reference CVE '41032?

@dcwhittaker
Copy link
Member Author

@gortok yes you are absolutely right - making those changes now. Thanks for the flag!

@leecow
Copy link
Member

leecow commented Oct 17, 2022

@KevinRansom or @jaredpar - do you know who should have a look at the F# to C# interop issue reported above (#7865 (comment))?

@mirespace
Copy link

Hi team,

(ofyi) I built dotnet7 RC2 amd64 today on Ubuntu (tarball creation included), and I got a different number for the version :

ubuntu@dotnet-jammy:~$ dotnet --info
.NET SDK:
 Version:   7.0.100-rc.2.22517.1
 Commit:    0a5360315a

Runtime Environment:
 OS Name:     ubuntu
 OS Version:  22.04
 OS Platform: Linux
 RID:         ubuntu.22.04-x64
 Base Path:   /usr/lib/dotnet/dotnet7-7.0.100-rc.2.22477.23/sdk/7.0.100-rc.2.22517.1/

I checked into the debian folder to see if that number was harcoded (It's strange to me that it could happen, but just double-checking), and it is not.

@jaredpar
Copy link
Member

I can repro @gdar91 issue.

  • Succeeded with RC1 SDK
  • Failed with RC2 SDK

I took a quick look at the F# binary produced by the RC2 SDK and it seems fine. At the same time I don't think we changed anything in C# import that would intersect with this.

@cston PTAL.

@cston
Copy link
Member

cston commented Oct 18, 2022

Regarding the issue reported by @gdar91 in #7865 (comment):

For the F# type type A = A previously the F# compiler emitted a type with a static property A and a get_A() method. With RC2 SDK, the type includes a get_A() method but no property.

@KevinRansom
Copy link
Member

Opened an issue in F#: dotnet/fsharp#14147

@vzarytovskii
Copy link
Member

vzarytovskii commented Oct 19, 2022

Reported earlier: dotnet/fsharp#14088
Fix has been backported to 17.4, the workaround is to disable generating reference assemblies for F# project:

<ProduceReferenceAssembly>false</ProduceReferenceAssembly>

@dcwhittaker
Copy link
Member Author

Closed in favor of #7939

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

9 participants