Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

API diff between .NET 8.0 and .NET 9 Preview 1 #9176

Merged
merged 8 commits into from Feb 21, 2024
Merged

API diff between .NET 8.0 and .NET 9 Preview 1 #9176

merged 8 commits into from Feb 21, 2024

Conversation

carlossanlop
Copy link
Member

Repos area owners:

Libraries area owners:

  • @dotnet/area-system-runtime
  • @dotnet/area-system-buffers
  • @dotnet/area-system-collections
  • @dotnet/area-system-io
  • @dotnet/area-system-linq
  • System.Net: @dotnet/ncl
  • @dotnet/area-system-reflection
  • @dotnet/area-system-reflection-emit
  • @dotnet/area-system-runtime-compilerservices
  • System.Runtime.InteropServices: @dotnet/interop-contrib
  • @dotnet/area-system-runtime-intrinsics
  • @dotnet/area-system-security
  • @dotnet/area-system-text-encoding
  • @dotnet/area-system-text-json
  • System.Threading: @mangod9 @kouvel
  • @dotnet/area-system-threading-tasks

Known api-diff tool issues:

  • The AsmDiff tool sometimes skips adding { or {}. Please provide a GitHub suggestion in this PR so we can correct it manually: arcade#10981
  • The AsmDiff tool shows APIs with decorating attribute changes as removed and re-added, instead of showing only the API. Please ignore this, it might be confusing but technically it's not incorrect: arcade#13814

@carlossanlop carlossanlop self-assigned this Feb 13, 2024
@carlossanlop carlossanlop mentioned this pull request Feb 13, 2024
Merged
@richlander
Copy link
Member

We have a preview1 folder now. Best to use it. Yes?

jkoritzinsky
jkoritzinsky reviewed Feb 14, 2024
View reviewed changes
Copy link
Member

@jkoritzinsky jkoritzinsky left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Two changes. Other than that, InteropServices.*, Compiler Services, and *PortableExecutable LGTM.

...ff/preview1/Microsoft.NETCore.App/9.0-preview1_System.Runtime.InteropServices.Marshalling.md Outdated Show resolved Hide resolved
...ff/preview1/Microsoft.NETCore.App/9.0-preview1_System.Runtime.InteropServices.Marshalling.md Outdated Show resolved Hide resolved
eiriktsarpalis
eiriktsarpalis approved these changes Feb 14, 2024
View reviewed changes
Copy link
Member

@eiriktsarpalis eiriktsarpalis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Collections, Linq and STJ changes LGTM

tannergooding
tannergooding approved these changes Feb 14, 2024
View reviewed changes
Copy link
Member

@tannergooding tannergooding left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

My areas look good.

adamsitnik
adamsitnik approved these changes Feb 16, 2024
View reviewed changes
Copy link
Member

@adamsitnik adamsitnik left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

System.IO and Microsoft.Extensions.Caching.Memory LGTM!

rzikm
rzikm approved these changes Feb 19, 2024
View reviewed changes
Copy link
Member

@rzikm rzikm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

System.Net.* LGTM

...se-notes/9.0/preview/api-diff/preview1/Microsoft.NETCore.App/9.0-preview1_System.Net.Quic.md Outdated Show resolved Hide resolved
...otes/9.0/preview/api-diff/preview1/Microsoft.NETCore.App/9.0-preview1_System.Net.Security.md Outdated Show resolved Hide resolved
release-notes/9.0/preview/api-diff/preview1/Microsoft.NETCore.App/9.0-preview1_System.Net.md Outdated Show resolved Hide resolved
@carlossanlop carlossanlop mentioned this pull request Feb 21, 2024
Open
@carlossanlop carlossanlop mentioned this pull request Feb 21, 2024
Open
@carlossanlop carlossanlop merged commit f59666e into dotnet:main Feb 21, 2024
3 checks passed
@carlossanlop carlossanlop deleted the ApiDiffPrev1 branch February 21, 2024 20:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jkoritzinsky jkoritzinsky jkoritzinsky left review comments

@stephentoub stephentoub stephentoub left review comments

@teo-tsirpanis teo-tsirpanis teo-tsirpanis left review comments

@kouvel kouvel kouvel left review comments

@buyaa-n buyaa-n buyaa-n left review comments

@eiriktsarpalis eiriktsarpalis eiriktsarpalis approved these changes

@adamsitnik adamsitnik adamsitnik approved these changes

@tannergooding tannergooding tannergooding approved these changes

@rzikm rzikm rzikm approved these changes

@rbhanda rbhanda Awaiting requested review from rbhanda rbhanda is a code owner

@leecow leecow Awaiting requested review from leecow leecow is a code owner

@richlander richlander Awaiting requested review from richlander

Assignees

@carlossanlop carlossanlop

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet