Unify remaining diverged misc types in corelib #10293
Comments
|
@maryamariyan after Microsoft.Win32 there are probably some of these that don't need too much context. |
|
For those that are seemingly horrible diffs, you can use git log to check whether they are simply an older version of CoreCLR. If so, very likely they can just be replaced with the CoreCLR version. |
|
Thanks @danmosemsft |
I doubt that there any in this issue where this would work. The relatively easy ones in this issue that I see are: Also, I found it useful to work on the horrible diffs incrementally. Once you identify pattern where things are different, fix that to make the diff less horrible. The files are still different, but less so - you can come to it later if it is not clear what to do about the rest. An example of such change is dotnet/corert#5765 . This change was actually fixing bug - the strategy to fix that bug was to unify one particular aspect of the file. |
…/System Related to: dotnet/coreclr#17904
…/System Related to: dotnet/coreclr#17904
Related to: dotnet/coreclr#17904
…shared Related to: dotnet/coreclr#17904
- InsufficientMemory, - OutOfMemory - ThreadInterrupted Related to: dotnet/coreclr#17904
- InsufficientMemory, - OutOfMemory - ThreadInterrupted Related to: dotnet/coreclr#17904
- InsufficientMemory, - OutOfMemory - ThreadInterrupted Related to: dotnet/coreclr#17904
- InsufficientMemory,
- OutOfMemory
- ThreadInterrupted
Related to: dotnet/coreclr#17904
|
@jkotas I looked at Please let me know if you still recommend modifying it further to be moved to shared. |
|
The cache implementation had to be split because of we did not have the public Hashtable in CoreLib. Now that the public Hashtable is in CoreLib, you can undo the split. |
…#18049) * Move following exceptions to shared: - InsufficientMemory, - OutOfMemory - ThreadInterrupted Related to: dotnet/coreclr#17904 Reduced diff in RegistryKey visible between coreclr and corert
… (#18049)
* Move following exceptions to shared:
- InsufficientMemory,
- OutOfMemory
- ThreadInterrupted
Related to: dotnet/coreclr#17904
Reduced diff in RegistryKey visible between coreclr and corert
Signed-off-by: dotnet-bot-corefx-mirror <dotnet-bot@microsoft.com>
… (#18049)
* Move following exceptions to shared:
- InsufficientMemory,
- OutOfMemory
- ThreadInterrupted
Related to: dotnet/coreclr#17904
Reduced diff in RegistryKey visible between coreclr and corert
Signed-off-by: dotnet-bot <dotnet-bot@microsoft.com>
… (#18049)
* Move following exceptions to shared:
- InsufficientMemory,
- OutOfMemory
- ThreadInterrupted
Related to: dotnet/coreclr#17904
Reduced diff in RegistryKey visible between coreclr and corert
Signed-off-by: dotnet-bot-corefx-mirror <dotnet-bot@microsoft.com>
… (#18049)
* Move following exceptions to shared:
- InsufficientMemory,
- OutOfMemory
- ThreadInterrupted
Related to: dotnet/coreclr#17904
Reduced diff in RegistryKey visible between coreclr and corert
Signed-off-by: dotnet-bot <dotnet-bot@microsoft.com>
|
Extracted decimal into its own issue https://github.com/dotnet/coreclr/issues/18249 |
ghost
locked as resolved and limited conversation to collaborators
We have reached the point that 60% of CoreCLR corelib code is shareable. We believe we can reasonably take this further, perhaps to 80% however much of the remaining reconciliation will take domain knowledge because the merges are not trivial. See #7394
From a diff of
corert\src\system.private.corelib\srcandcoreclr\src\mscorlib\srcthese are files whose implementations are yet to be unified. In some cases this will take care. In some happy cases the CoreRT code may just be a frozen old copy of the CoreCLR code from years ago in which case possibly resolution may be just "take coreclr". Once implementations have been reconciled, the shared copy should move under "shared" and the other copies deleted.Some of these will be specific to CoreCLR/CoreRT and those obviously should stay as they are.
The text was updated successfully, but these errors were encountered: