No source/line info for unhandled exceptions displayed on the console.

[mikem8361]

When an exception goes unhandled, the exception call stack doesn't include the source line numbers. On the other hand, the source line numbers are included when Exception.ToString() or Exception.StackTrace is called on an exception object.

The fix is going to be interesting (difficult) because all of this happens in native coreclr code (DefaultCatchHandlerExceptionMessageWorker).

[mikem8361]

The fix is as simple as removing the code below in Exception.InternalToString() because it is called from the vm native code for unhandled exceptions except for the comment about AppDomains being sandboxed and watson bucket generation. I’m pretty sure that doesn’t apply to xplat but it may still be a problem with coreclr on Windows.

        // Get the current stack trace string.  On CoreCLR we don't bother
        // to try and include file/line-number information because all AppDomains
        // are sandboxed, and so this won't succeed in most (or all) cases.  Therefore the
        // Demand and exception overhead is a waste.
        // We currently have some bugs in watson bucket generation where the SecurityException
        // here causes us to lose saved bucket parameters.  By not even doing the demand
        // we avoid those problems (although there are deep underlying problems that need to
        // be fixed there - relying on this to avoid problems is incomplete and brittle).
        bool fGetFileLineInfo = true;

#if FEATURE_CORECLR
fGetFileLineInfo = false;
#endif
return ToString(fGetFileLineInfo, true);