Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Consider avoiding using "which" to validate prereqs #6555

Closed
mellinoe opened this issue Aug 24, 2016 · 3 comments · Fixed by dotnet/coreclr#6994
Closed

Consider avoiding using "which" to validate prereqs #6555

mellinoe opened this issue Aug 24, 2016 · 3 comments · Fixed by dotnet/coreclr#6994

Comments

@mellinoe
Copy link
Contributor

which is not universally available, and is not even installed by default in some cases (docker images). We should consider using a more universally available method for checking. Answers online recommend using command or type to do this.

@mellinoe
Copy link
Contributor Author

This is what I'm referring to, for clarity.

# resolve python-version to use
if [ "$PYTHON" == "" ] ; then
    if which python >/dev/null 2>&1
    then
       PYTHON=python
    elif which python2 >/dev/null 2>&1
    then
       PYTHON=python2
...

@adityamandaleeka
Copy link
Member

I've opened a PR to address this.

@jkotas
Copy link
Member

jkotas commented Sep 1, 2016

Rolled back in dotnet/coreclr#7025

@msftgits msftgits transferred this issue from dotnet/coreclr Jan 31, 2020
@ghost ghost locked as resolved and limited conversation to collaborators Dec 29, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants