Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Review FEATURE_CORESYSTEM #7411

Closed
danmoseley opened this issue Feb 11, 2017 · 2 comments · Fixed by #63850
Closed

Review FEATURE_CORESYSTEM #7411

danmoseley opened this issue Feb 11, 2017 · 2 comments · Fixed by #63850
Labels
area-Meta enhancement Product code improvement that does NOT require public API changes/additions
Milestone
Future

Comments

@danmoseley
Copy link
Member

We always define it but apparently there is some worthwhile code that is lost when we do this: dotnet/coreclr#9525 (comment)

Go through all instances and take the "defined" or "undefined" path as appropriate.

They can be found by running a command like this
coan-6.0.1-x86_64.exe source -K -R -DFEATURE_CORESYSTEM -Fcpp,h,rc,inl,hpp,src,txt,idl .

These have the changes but they may get git-GCd' --
dotnet/coreclr@751771a
dotnet/coreclr@52009b8
@jkotas
Copy link
Member

jkotas commented Feb 11, 2017

  • Use faster STL hashtables in DAC if possible
  • Keep mixed mode debugging bits under debug\dbi?
  • Keep more precise process afinity computation?
  • More dead code can be removed (e.g. everything under IsWindows7Platform)

@danmoseley
Copy link
Member Author

Also grep for
coresystemtodo
CORESYSTEM TODO
CORESYSTODO

@msftgits msftgits transferred this issue from dotnet/coreclr Jan 31, 2020
@msftgits msftgits added this to the Future milestone Jan 31, 2020
@maryamariyan maryamariyan added the untriaged New issue has not been triaged by the area owner label Feb 26, 2020
@ericstj ericstj removed the untriaged New issue has not been triaged by the area owner label Jun 25, 2020
@joperezr joperezr added this to Needs triage in Triage POD for Meta, Reflection, etc via automation Jan 29, 2021
@joperezr joperezr moved this from Needs triage to Future in Triage POD for Meta, Reflection, etc Jan 29, 2021
@AaronRobinsonMSFT AaronRobinsonMSFT mentioned this issue Jan 16, 2022
Merged
@ghost ghost added the in-pr There is an active PR which will close this issue when it is merged label Jan 16, 2022
@ghost ghost removed the in-pr There is an active PR which will close this issue when it is merged label Jan 26, 2022
@ghost ghost locked as resolved and limited conversation to collaborators Feb 25, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
area-Meta enhancement Product code improvement that does NOT require public API changes/additions
Projects
No open projects
Triage POD for Reflection, META, etc.
Status: Done
Milestone
Future
Development

Successfully merging a pull request may close this issue.

Remove usage of FEATURE_CORESYSTEM AaronRobinsonMSFT/runtime
5 participants
@maryamariyan @danmoseley @jkotas @ericstj @msftgits