Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Already on GitHub? Sign in to your account

Incorrect loop variable #10414

Merged
merged 1 commit into from Mar 23, 2017

Conversation

Projects
None yet
5 participants
Contributor

DieselMachine84 commented Mar 23, 2017

I used PVS-Studio static analyzer to check this project. I would like to suggest a variant of the way to fix the error, detected with the help of V534 diagnostic. Description of the diagnostic: https://www.viva64.com/en/examples/v534/

Incorrect variable 'i' from the outer loop is used in condition of the inner loop.

I used PVS-Studio static analyzer to check this project. I would like…
… to suggest a variant of the way to fix the error, detected with the help of V534 diagnostic. Description of the diagnostic: https://www.viva64.com/en/examples/v534/

Incorrect variable 'i' from the outer loop is used in condition of the inner loop.

LGTM, thank you!

@janvorli janvorli merged commit 5bcd081 into dotnet:master Mar 23, 2017

15 checks passed

CentOS7.1 x64 Debug Build and Test Build finished.
Details
FreeBSD x64 Checked Build Build finished.
Details
OSX10.12 x64 Checked Build and Test Build finished.
Details
Tizen armel Cross Debug Build Build finished.
Details
Tizen armel Cross Release Build Build finished.
Details
Ubuntu arm Cross Release Build Build finished.
Details
Ubuntu x64 Checked Build and Test Build finished.
Details
Ubuntu x64 Formatting Build finished.
Details
Ubuntu16.04 arm Cross Debug Build Build finished.
Details
Windows_NT arm Cross Debug Build Build finished.
Details
Windows_NT arm Cross Release Build Build finished.
Details
Windows_NT x64 Debug Build and Test Build finished.
Details
Windows_NT x64 Formatting Build finished.
Details
Windows_NT x64 Release Priority 1 Build and Test Build finished.
Details
Windows_NT x86 Checked Build and Test Build finished.
Details

jorive added a commit to guhuro/coreclr that referenced this pull request May 4, 2017

I used PVS-Studio static analyzer to check this project. I would like…
… to suggest a variant of the way to fix the error, detected with the help of V534 diagnostic. Description of the diagnostic: https://www.viva64.com/en/examples/v534/ (#10414)

Incorrect variable 'i' from the outer loop is used in condition of the inner loop.

@karelz karelz modified the milestone: 2.0.0 Aug 28, 2017

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment