This repository has been archived by the owner on Jan 23, 2023. It is now read-only.
[ARM/Linux] Honor unaligned prefix for ldobj instruction #11224
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
parjong
changed the title
|
@dotnet/jit-contrib @BruceForstall Could you please take a look? |
BruceForstall
approved these changes
Apr 27, 2017
|
fyi @dotnet/arm32-contrib : Note that for RyuJIT/arm32, there is no code yet to to handle |
|
@BruceForstall Thank you for the information. #11284 will track this issue in ryujit/arm32. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It seems that importer currently ignores unaligned. prefix when it imports ldobj instruction, which results in #11200.
This commit attempts to (partially) fix #11200 on the following cases (when the object is of primitive type):