This repository has been archived by the owner on Jan 23, 2023. It is now read-only.
Fix std::out_of_range exception with short filenames (Linux) #119
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
An unsigned integer was being used while scanning the CLR path to locate assemblies. If a file existed in the directory with a name shorter than the longest extension being checked for (.ni.dll), then the variable would underflow and cause an exception when used as an index on the filename.
|
LGTM, thanks for fixing it. |
|
@jkotas Could you please take a look and merge if you are ok? |
|
LGTM |
jkotas
added a commit
that referenced
this pull request
Feb 7, 2015
Fix std::out_of_range exception with short filenames (Linux)
franksinankaya
added a commit
to franksinankaya/coreclr
that referenced
this pull request
Apr 3, 2020
franksinankaya
added a commit
to franksinankaya/coreclr
that referenced
this pull request
Apr 3, 2020
movs r7, dotnet#119
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
An unsigned integer was being used while scanning the CLR path to locate assemblies. If a file existed in the directory with a name shorter than the longest extension being checked for (.ni.dll), then the variable would underflow and cause an exception when used as an index on the filename.
$ touch 123456
$ ./corerun hello.exe
terminate called after throwing an instance of 'std::out_of_range'
what(): basic_string::compare: __pos (which is 18446744073709551615) > this->size() (which is 6)
Aborted (core dumped)