Add support for not breaking build on warnings #12039
Conversation
|
I am totally not sure of the best name for the cmake option and the flag to build.sh. Any suggestions are welcome! |
CMakeLists.txt
Outdated
| @@ -32,6 +32,7 @@ if(CORECLR_SET_RPATH) | |||
| endif(CORECLR_SET_RPATH) | |||
|
|
|||
| OPTION(CMAKE_ENABLE_CODE_COVERAGE "Enable code coverage" OFF) | |||
| OPTION(CMAKE_WARNINGS_ARE_ERRORS "Warnings are errors" ON) | |||
There was a problem hiding this comment.
Can you please name the option CLR_CMAKE_WARNINGS_ARE_ERRORS instead? Besides that option above that I've not noticed during past PRs, we don't use options starting with CMAKE_, since that is reserved for variables of the cmake itself. And if you could also rename the CMAKE_ENABLE_CODE_COVERAGE, it would be awesome.
|
Thanks for the review. I will make the suggested changes. One more question: do I need to implement this on the Windows side as well ( |
Add a build flag to make -Werror optional and let the build continue even in the presence of warnings. This option is very useful for anyone compiling with a different (version of the) compiler. A different (version of the) compiler may produce a different set of warnings and a piece of code that compiles without warnings may emit warnings with a different (version of the) compiler. Resolves https://github.com/dotnet/coreclr/issues/8586
|
@omajid while it would be nice to do it on Windows side too, someone else can do it over there if you don't have windows box. Please just create an issue for it. |
|
No problem! I filed https://github.com/dotnet/coreclr/issues/12061. I will open a separate PR for |
|
Thanks for merging this! |
Add a build flag to make -Werror optional and let the build continue even in the presence of warnings. This option is very useful for anyone compiling with a different (version of the) compiler. A different (version of the) compiler may produce a different set of warnings and a piece of code that compiles without warnings may emit warnings with a different (version of the) compiler. Resolves https://github.com/dotnet/coreclr/issues/8586
Add a build flag to make
-Werroroptional and let the build continue even in the presence of warnings.This option is very useful for anyone compiling with a different (version of the) compiler. A different (version of the) compiler may produce a different set of warnings and a piece of code that compiles
without warnings may emit warnings with a different (version of the) compiler.
Resolves https://github.com/dotnet/coreclr/issues/8586