This repository has been archived by the owner on Jan 23, 2023. It is now read-only.
Clear the init-locals bit for CoreLib to workaround #1279 #13728
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
stephentoub
reviewed
Aug 31, 2017
| int numVirtuals = RuntimeTypeHandle.GetNumVirtuals(declaringType); | ||
|
|
||
| bool* overrides = stackalloc bool[numVirtuals]; | ||
| new Span<bool>(overrides, numVirtuals).Clear(); |
There was a problem hiding this comment.
I'd previously tried running all of the corefx tests with that hack to disable init locals, and I'd seen maybe three or four tests fail total... I assume this is the fix for those?
There was a problem hiding this comment.
Yes, this place in CoreLib used to depend on stackalloced memory to be zero-initialized. I have just found a second one in TraceLoggingEventSource.cs.
|
|
|
@dotnet-bot test this please |
|
@dotnet-bot test Ubuntu16.04 arm Cross Debug Build please |
|
@dotnet-bot test Ubuntu x64 Checked Build and Test please |
1 similar comment
|
@dotnet-bot test Ubuntu x64 Checked Build and Test please |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.