This repository has been archived by the owner on Jan 23, 2023. It is now read-only.
Add support for building under glibc 2.26 #13785
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
janvorli
reviewed
Sep 5, 2017
src/pal/src/include/pal/context.h
Outdated
| @@ -21,6 +21,8 @@ Module Name: | |||
| #ifndef _PAL_CONTEXT_H_ | |||
| #define _PAL_CONTEXT_H_ | |||
|
|
|||
| #include "config.h" | |||
There was a problem hiding this comment.
A nit - this is not needed. The config.h is included in palinternal.h that needs to be always included before this header. We already use a couple of HAVE_xxxx macros in this file.
glibc 2.26 renames a number of identifiers so they are reserved under POSIX. Specifically, `padding` becomes `__glibc_reserved1`. Add a configure test for it and use the appropriate field name. See https://sourceware.org/bugzilla/show_bug.cgi?id=21457 for more information. Resolves #13009
|
@dotnet-bot test OSX10.12 x64 Checked Build and Test Failure was regexdna which is known flaky. |
|
Thanks for the review and merging this! |
ljrk0
pushed a commit
to ljrk0/coreclr
that referenced
this pull request
Oct 18, 2017
glibc 2.26 renames a number of identifiers so they are reserved under POSIX. Specifically, `padding` becomes `__glibc_reserved1`. Add a configure test for it and use the appropriate field name. See https://sourceware.org/bugzilla/show_bug.cgi?id=21457 for more information. Resolves #13009
mchataigner
pushed a commit
to mchataigner/coreclr
that referenced
this pull request
Oct 25, 2017
glibc 2.26 renames a number of identifiers so they are reserved under POSIX. Specifically, `padding` becomes `__glibc_reserved1`. Add a configure test for it and use the appropriate field name. See https://sourceware.org/bugzilla/show_bug.cgi?id=21457 for more information. Resolves #13009
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
glibc 2.26 renames a number of identifiers so they are reserved under POSIX. Specifically,
paddingbecomes__glibc_reserved1. Add a configure test for it and use the appropriate field name.See https://sourceware.org/bugzilla/show_bug.cgi?id=21457 for more information.
Resolves #13009